add touch-icon with background

[NiTRoeSE]

To prevent this ugly glitch while minimize app to homescreen because of transparent background of favicon.

You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.

[codecov-io]

Codecov Report

Merging #10022 into master will increase coverage by <.01%.
The diff coverage is 41.69%.

@@            Coverage Diff             @@
##           master   #10022      +/-   ##
==========================================
+ Coverage   42.26%   42.27%   +<.01%     
==========================================
  Files         611      616       +5     
  Lines       80407    80742     +335     
==========================================
+ Hits        33983    34132     +149     
- Misses      42244    42410     +166     
- Partials     4180     4200      +20

Impacted Files	Coverage Δ
modules/queue/queue.go	26.82% <0%> (-8.47%)	⬇️
routers/admin/admin.go	10.64% <0%> (-0.57%)	⬇️
modules/migrations/gitea.go	6.14% <0%> (ø)	⬆️
routers/private/manager_unix.go	0% <0%> (ø)
services/pull/review.go	0% <0%> (ø)	⬆️
cmd/manager.go	0% <0%> (ø)
routers/repo/commit.go	29.66% <0%> (ø)	⬆️
routers/private/manager.go	0% <0%> (ø)
modules/graceful/manager_unix.go	40.83% <0%> (-2.53%)	⬇️
modules/queue/queue_redis.go	1.48% <0%> (+0.06%)	⬆️
... and 43 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f718b50...4946b72. Read the comment docs.

[silverwind]

Those images come from this make task, so it'd need to be added there. As for adding the background, you could try something like convert favicon.png -fill white -opaque none apple-touch-icon.png.

[NiTRoeSE]

Those images come from this make task, so it'd need to be added there. As for adding the background, you could try something like convert favicon.png -fill white -opaque none apple-touch-icon.png.

.. thanks for the hint, in fact i have no clue from go but wanted to help to fix this little cosmetic problem. ☺️ ..I hope its now in a correct way, if not i think its better that someone which have the needed knowledge do this job. regards 🙂

[techknowlogick]

in fact i have no clue from go but wanted to help to fix this little cosmetic problem

no worries. thanks for this PR :) I think one last thing that needs to be done is if you run the make task and then commit the generated image from that

[lafriks]

Generated image still needs to be included in conmit

[lafriks]

Generated icon missing

I've run make command

[silverwind]

The image still has some transparent pixels left, making it look bad on a dark background:

I'd say revert this commit. If IOS can not deal with transparency, it's IOS's fault, not ours. I certainly prefer transparency over a opinionated white background. It certainly does not look out of place to me in the animation in the OP.

[NiTRoeSE]

The image still has some transparent pixels left, making it look bad on a dark background:

I'd say revert this commit. If IOS can not deal with transparency, it's IOS's fault, not ours. I certainly prefer transparency over a opinionated white background. It certainly does not look out of place to me in the animation in the OP.

I ran make yesterday in the the evening, i needed more time to figure out how to do it because its my first time with go. As far i could see yesterday there was no transparency left and the icon looked good. I take a look again this evening and give feedback here..

Except of this .. why not just add an photoshop generated icon for this case ? (I could create one...) Or in other words, why must it be generated through makefile?

[6543]

@NiTRoeSE it doesnt have to ... For me generate-images looks like a relict from the past ...
@techknowlogick any opinion of removing generate-images or just leave it as it is ...?

[NiTRoeSE]

it doesnt have to ... For me generate-images looks like a relict from the past ...

I'm sorry if I have initiated a discussion of principles about the icon now.
I just asking to better understand why this is done in this way. ( I'm newby to this project ;) )
For me its also okay if the commit is reverted. I think its also possible to achieve the goal simply through customizing possibilities from Gitea. So i just want to say.. i completely understand if there is no time to investigate in such a small cosmetic "problem". ;)

If you guys want to investigate and need icons made with photoshop , then i will gladly offer my help.

[6543]

@NiTRoeSE I think just creat a new pull and add your the icon you mad with your photo-edit-software ;)

and hopefully this time we dont need to revert 😓

[6543]

@silverwind to:

If IOS can not deal with transparency, it's IOS ...

if i understand correctly rel="apple-touch-icon" is only take in account by apple?
so if we add a icon for apple devices it wont afect android/wind/co ...
so why not generate a icon for ios manualy :) as @NiTRoeSE proposed to create one

[silverwind]

Fix PR: #10065