Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependents on macaron from modules/setting #10050

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 29, 2020

Fix #6927

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jan 29, 2020
@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #10050 into master will increase coverage by 0.01%.
The diff coverage is 45.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10050      +/-   ##
==========================================
+ Coverage   42.26%   42.28%   +0.01%     
==========================================
  Files         616      618       +2     
  Lines       80755    80755              
==========================================
+ Hits        34129    34145      +16     
+ Misses      42423    42410      -13     
+ Partials     4203     4200       -3
Impacted Files Coverage Δ
routers/api/v1/repo/repo.go 76.22% <ø> (+6.95%) ⬆️
routers/api/v1/repo/mirror.go 0% <0%> (ø)
routers/api/v1/repo/migrate.go 54.6% <54.6%> (ø)
models/repo.go 49.66% <0%> (-0.14%) ⬇️
models/error.go 31.31% <0%> (+0.54%) ⬆️
services/pull/patch.go 66.03% <0%> (+1.25%) ⬆️
modules/queue/workerpool.go 48.39% <0%> (+1.77%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561cb62...f63e384. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2020
@lunny lunny changed the title Movde dependents on macaron from modules/setting Move dependents on macaron from modules/setting Jan 29, 2020
@lafriks lafriks added this to the 1.12.0 milestone Jan 29, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 29, 2020
@zeripath
Copy link
Contributor

Make lg-tm work

@lafriks lafriks merged commit 79ce91f into go-gitea:master Jan 29, 2020
@lunny lunny deleted the lunny/setting_undepend_macaron branch January 29, 2020 07:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

models should not depend on macaron
6 participants