-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dependents on macaron from modules/setting #10050
Merged
lafriks
merged 3 commits into
go-gitea:master
from
lunny:lunny/setting_undepend_macaron
Jan 29, 2020
Merged
Move dependents on macaron from modules/setting #10050
lafriks
merged 3 commits into
go-gitea:master
from
lunny:lunny/setting_undepend_macaron
Jan 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10050 +/- ##
==========================================
+ Coverage 42.26% 42.28% +0.01%
==========================================
Files 616 618 +2
Lines 80755 80755
==========================================
+ Hits 34129 34145 +16
+ Misses 42423 42410 -13
+ Partials 4203 4200 -3
Continue to review full report at Codecov.
|
6543
approved these changes
Jan 29, 2020
zeripath
approved these changes
Jan 29, 2020
lafriks
approved these changes
Jan 29, 2020
Make lg-tm work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
topic/build
PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6927