Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RACE_ENABLED=1 envs for make test* #10055

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Add RACE_ENABLED=1 envs for make test* #10055

merged 1 commit into from
Jan 29, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 29, 2020

Copied from #1441.

So that you can run test with race detection as

RACE_ENABLED=1 make test-sqlite#TestXXX

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 29, 2020
bagasme
bagasme reviewed Jan 29, 2020
View reviewed changes
Makefile
Comment on lines +33 to +36
ifneq ($(RACE_ENABLED),)
GOTESTFLAGS ?= -race
endif

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bagasme -> https://blog.golang.org/race-detector

6543
6543 approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice option

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2020
@zeripath zeripath merged commit e2c505f into go-gitea:master Jan 29, 2020
@lunny lunny deleted the lunny/enable_race_makefile branch January 30, 2020 01:55
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@bagasme bagasme bagasme left review comments

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @zeripath @6543 @bagasme @GiteaBot