-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove VERSIONS file #10070
remove VERSIONS file #10070
Conversation
It serves no clear purpose and is not used anywhere to my knowledge. Also, it's name to version mapping doesn't work with bundling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, as it was duplicate from librejs.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it was considdered as cinfig for somethinge like webpack ...
So we dont need it anymore
The only purpose it could have to us now is when porting the remaining libs to webpack as a version reference in case data is missing in librejs.html, but I can just look up this commit if needed. |
Codecov Report
@@ Coverage Diff @@
## master #10070 +/- ##
==========================================
+ Coverage 42.31% 43.46% +1.15%
==========================================
Files 618 566 -52
Lines 80850 79024 -1826
==========================================
+ Hits 34211 34348 +137
+ Misses 42431 40437 -1994
- Partials 4208 4239 +31
Continue to review full report at Codecov.
|
make lg-tm work |
It serves no clear purpose and is not used anywhere to my knowledge. Also, it's name to version mapping doesn't work with bundling.