Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove VERSIONS file #10070

Merged
merged 4 commits into from
Feb 1, 2020
Merged

remove VERSIONS file #10070

merged 4 commits into from
Feb 1, 2020

Conversation

silverwind
Copy link
Member

It serves no clear purpose and is not used anywhere to my knowledge. Also, it's name to version mapping doesn't work with bundling.

It serves no clear purpose and is not used anywhere to my knowledge.
Also, it's name to version mapping doesn't work with bundling.
Copy link
Contributor

@bagasme bagasme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, as it was duplicate from librejs.html

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 30, 2020
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was considdered as cinfig for somethinge like webpack ...

So we dont need it anymore

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 30, 2020
@silverwind
Copy link
Member Author

The only purpose it could have to us now is when porting the remaining libs to webpack as a version reference in case data is missing in librejs.html, but I can just look up this commit if needed.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 30, 2020
@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 30, 2020
@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #10070 into master will increase coverage by 1.15%.
The diff coverage is 50.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10070      +/-   ##
==========================================
+ Coverage   42.31%   43.46%   +1.15%     
==========================================
  Files         618      566      -52     
  Lines       80850    79024    -1826     
==========================================
+ Hits        34211    34348     +137     
+ Misses      42431    40437    -1994     
- Partials     4208     4239      +31
Impacted Files Coverage Δ
modules/structs/repo.go 36.36% <ø> (ø) ⬆️
routers/repo/setting.go 15.01% <0%> (+0.02%) ⬆️
models/migrations/v76.go 0% <0%> (ø) ⬆️
models/migrations/v70.go 0% <0%> (ø) ⬆️
models/repo.go 51.33% <0%> (+1.53%) ⬆️
models/migrations/v126.go 0% <0%> (ø)
models/user.go 49.15% <0%> (-0.13%) ⬇️
models/migrations/migrations.go 4.16% <0%> (+2.86%) ⬆️
services/pull/pull.go 33.93% <0%> (ø) ⬆️
routers/repo/branch.go 55.72% <100%> (+0.34%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54327c7...216317a. Read the comment docs.

@zeripath
Copy link
Contributor

zeripath commented Feb 1, 2020

make lg-tm work

@zeripath zeripath merged commit 046bb05 into go-gitea:master Feb 1, 2020
@silverwind silverwind deleted the rm-versions branch February 5, 2020 23:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants