Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative Config path combined with Custom-PATH #10082

Closed
6543 opened this issue Jan 31, 2020 · 11 comments
Closed

relative Config path combined with Custom-PATH #10082

6543 opened this issue Jan 31, 2020 · 11 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented

Comments

@6543
Copy link
Member

6543 commented Jan 31, 2020

./gitea --config ./custom/conf/app.1.11.ini
will create&use a config at ./custom/custom/conf/app.1.11.ini

gitea version: current master
1.11.x also afected

@6543

This comment has been minimized.

@lunny
Copy link
Member

lunny commented Jan 31, 2020

So the expected is a relative path to current directory.

@6543
Copy link
Member Author

6543 commented Jan 31, 2020

if i put a ./ on a relative path i expect it is the same as $(pwd)/

@6543
Copy link
Member Author

6543 commented Jan 31, 2020

but in generell i would not expect path change when using relative paths

@6543 6543 changed the title config path issue relative Config path combined with Custom-PATH Jan 31, 2020
@6543
Copy link
Member Author

6543 commented Jan 31, 2020

} else if !filepath.IsAbs(CustomConf) {
CustomConf = path.Join(CustomPath, CustomConf)
}

@guillep2k
Copy link
Member

Yes, I've noticed this problem when I added the path info to the doctor. Config path is relative to custom dir, not to the current working directory as I expected. Not a fan of that, but I guess that changing that behaviour would be quite breaking, especially because we create app.ini if we don't find it.

@zeripath
Copy link
Contributor

zeripath commented Feb 1, 2020

Yup. It's difficult to change once it's there - that's why I kept it that way.

Gitea 2?

@stale
Copy link

stale bot commented Apr 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 1, 2020
@6543
Copy link
Member Author

6543 commented Apr 1, 2020

ping - we can leave the funct as it wors but add a check if path starts with ./ <- if so its relative to current path

@stale stale bot removed the issue/stale label Apr 1, 2020
@stale
Copy link

stale bot commented May 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label May 31, 2020
@zeripath zeripath added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jun 1, 2020
@stale stale bot removed the issue/stale label Jun 1, 2020
@6543
Copy link
Member Author

6543 commented Jun 2, 2020

works on current version - dont know why

think some updated lib did the job

@6543 6543 closed this as completed Jun 2, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented
Projects
None yet
Development

No branches or pull requests

4 participants