Accept punctuation after simple+cross repository issue references

[guillep2k]

This PR adds ,, ; and : as valid characters following a simple issue or PR ref, as long as there's a spacing character following:

#123 was supported.
#123. was supported.
#123, was not supported, now it is.
#123; was not supported, now it is.
#123: was not supported, now it is.
#123.456 is not supported.

Attempts to close (?) #10074, but I've left a few cases out; I feel a little uncomfortable trying to read too much out of the text with just a regexp, I don't want to start getting too many false positives:

• I didn't add question or exclamation marks... Seems excesive? I think exclamation marks look weird in the case of PRs (Look at !1234!) but it may work with issues (Look at #1234!).
• I did this only for simple and cross repository references, not external alphanumeric (AAAA-1234) references.

Fixes #10074

[codecov-io]

Codecov Report

Merging #10091 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10091      +/-   ##
==========================================
- Coverage   43.48%   43.45%   -0.03%     
==========================================
  Files         566      566              
  Lines       79024    79024              
==========================================
- Hits        34366    34343      -23     
- Misses      40421    40441      +20     
- Partials     4237     4240       +3

Impacted Files	Coverage Δ
services/pull/patch.go	66.03% <0%> (-3.78%)	⬇️
modules/process/manager.go	74.69% <0%> (-3.62%)	⬇️
modules/queue/workerpool.go	46.61% <0%> (-2.5%)	⬇️
models/unit.go	37.03% <0%> (-2.47%)	⬇️
modules/log/file.go	75.52% <0%> (-2.1%)	⬇️
routers/repo/view.go	38.59% <0%> (-0.88%)	⬇️
models/repo.go	51.33% <0%> (-0.14%)	⬇️
services/pull/pull.go	34.23% <0%> (+0.3%)	⬆️
modules/queue/manager.go	62.05% <0%> (+1.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3606ee...5535773. Read the comment docs.

[6543]

i think it close #10074

[lunny]

And ? and !?

Can ? and ! be supported as well? I think if the rule is the same (space or EOL immediately after) then it isn't ambiguous, but I can say nothing about the troubles to implement that.

[guillep2k]

And ? and !?

No problem, I can add those.

[zeripath]

As per above awaiting addition of ? and !

[guillep2k]

Added ! and ?. Fixed a bug where mentions/references were not detected if they were consecutive and shared a space:

......._REF1_REF2_.....
.......XXXXXX..........
............YYYYYY.....

This was not apparent in markdown rendering because the function takes them one by one.

[guillep2k]

And ? and !?

@lunny done.