Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] expose RepoOwner on Issue response #10126

Merged
merged 4 commits into from
Feb 4, 2020
Merged

[API] expose RepoOwner on Issue response #10126

merged 4 commits into from
Feb 4, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 3, 2020

close #10112

@codecov-io
Copy link

codecov-io commented Feb 3, 2020 •
edited
Loading

Codecov Report

Merging #10126 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10126      +/-   ##
==========================================
- Coverage    43.4%    43.4%   -0.01%     
==========================================
  Files         576      576              
  Lines       79637    79624      -13     
==========================================
- Hits        34568    34557      -11     
  Misses      40789    40789              
+ Partials     4280     4278       -2
Impacted Files Coverage Δ
modules/templates/helper.go 40.36% <ø> (ø) ⬆️
modules/base/tool.go 62.94% <100%> (-1.83%) ⬇️
services/pull/check.go 31.48% <0%> (-1.86%) ⬇️
models/error.go 30.4% <0%> (-0.55%) ⬇️
models/gpg_key.go 55.37% <0%> (+0.55%) ⬆️
services/pull/pull.go 33.93% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b4771f...227fddc. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 3, 2020
@lunny lunny added the modifies/api This PR adds API routes or modifies them label Feb 4, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 4, 2020
@techknowlogick techknowlogick changed the title [API] expose RepoOwner on Issue responce [API] expose RepoOwner on Issue response Feb 4, 2020
@techknowlogick techknowlogick merged commit b3c72a7 into go-gitea:master Feb 4, 2020
@6543 6543 deleted the api-get-repoOwner branch February 4, 2020 05:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API] Issue Repo dont return repoOwner
6 participants
@6543 @codecov-io @lunny @guillep2k @techknowlogick @GiteaBot