Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] move APIFormat() of Issue and Label to convert package #10423

Merged
merged 14 commits into from
Feb 29, 2020
Merged

[Refactor] move APIFormat() of Issue and Label to convert package #10423

merged 14 commits into from
Feb 29, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 23, 2020

code refactor ...

@6543 6543 changed the title Label: delete .APIFormat() and use convert.ToLabel() Refactor: move APIFormat() of Issue and Lable to convert package Feb 23, 2020
@6543 6543 changed the title Refactor: move APIFormat() of Issue and Lable to convert package [Refactor] move APIFormat() of Issue and Lable to convert package Feb 23, 2020
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 23, 2020
@codecov-io
Copy link

codecov-io commented Feb 23, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@2d345e6). Click here to learn what that means.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10423   +/-   ##
=========================================
  Coverage          ?   43.66%           
=========================================
  Files             ?      586           
  Lines             ?    81389           
  Branches          ?        0           
=========================================
  Hits              ?    35539           
  Misses            ?    41440           
  Partials          ?     4410
Impacted Files Coverage Δ
models/token.go 73.77% <0%> (ø)
models/issue_watch.go 58.53% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d345e6...bd35931. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 23, 2020
@6543
Copy link
Member Author

6543 commented Feb 23, 2020

@lunny can you have a look at this pleace?

@zeripath zeripath changed the title [Refactor] move APIFormat() of Issue and Lable to convert package [Refactor] move APIFormat() of Issue and Label to convert package Feb 23, 2020
@lunny
Copy link
Member

lunny commented Feb 24, 2020

CI is still failed.

@6543
Copy link
Member Author

6543 commented Feb 24, 2020

@lunny It looks unrelated and tests pass localy - so :( ... wayt to hit the "update branch" buton ;)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2020
@6543
Copy link
Member Author

6543 commented Feb 28, 2020

@lunny CI passed 3 times now

guillep2k
guillep2k approved these changes Feb 29, 2020
View reviewed changes
modules/convert/issue.go Show resolved Hide resolved
modules/convert/issue.go Outdated Show resolved Hide resolved
modules/convert/issue.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 29, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone Feb 29, 2020
@techknowlogick
Copy link
Member

ping @6543

6543 and others added 2 commits February 29, 2020 03:17
@6543
Merge branch 'master' into refactor_issueLableConvert
1bb7274
@6543 @guillep2k
Apply suggestions from code review
2dc75a3 
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@guillep2k guillep2k merged commit 7e8cdba into go-gitea:master Feb 29, 2020
@6543 6543 deleted the refactor_issueLableConvert branch February 29, 2020 02:51
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@6543 @codecov-io @lunny @techknowlogick @zeripath @guillep2k @GiteaBot