Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ for markdown #10611

Merged
merged 3 commits into from Mar 5, 2020
Merged

Add FAQ for markdown #10611

merged 3 commits into from Mar 5, 2020

Conversation

jolheiser
Copy link
Member

Resolves #10223

Some changes to markdown are actually not bugs, but rather non-compliant with CommonMark.
Sometimes there are actually compliant alternatives, though, so it may be important to make users aware. 馃檪

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 5, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 5, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>

## Why is my markdown broken
In Gitea version `1.11` we moved to [goldmark](https://github.com/yuin/goldmark) for markdown rendering, which is [CommonMark](https://commonmark.org/) compliant.
If you have markdown that worked as you expected prior to version `1.11` and after upgrading it's not working anymore, please look through the CommonMark spec to see whether the problem is due to a bug or non-compliant syntax.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillep2k I re-worded a little, is this better?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 5, 2020
@jolheiser
Copy link
Member Author

Ping lgtm

@jolheiser jolheiser merged commit 10081f8 into go-gitea:master Mar 5, 2020
@jolheiser jolheiser deleted the faq-markdown branch March 5, 2020 15:05
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown links with whitespace can no longer be resolved in Wiki
4 participants