Fix task-list checkbox styling

[cipherboy]

This pull request does two things:

• Resolves Missing space after checkbox #9656, by updating goldmark to v1.1.25 to incorporate goldmark-pr#112.
• Styles task-lists to remove the bullets, when rendered with pandoc.

#9656 strictly describes the missing space. However, commenters asked for the bullet to be removed as well. This is a little more tricky as the GFM spec doesn't mention adding a class to the <ul> (the way pandoc does). It might be possible to convince the goldmark maintainer to add that class though, I'm not sure.

An alternative is to wait until CSS4 selectors are available. This should include the :has() selector, which would allow us to select based on containing an input field. Something like li:has(input[type="checkbox"]). But caniuse says I can't use it because nobody supports it.

---

When rendered with Pandoc, it now looks like:

---

When rendered with Goldmark, it now looks like:

---

Note: I'm using go v1.13.6 and it looks like the go.sum file didn't change correctly. What version of go should I be using to match this project's go.sum file preferences?

[silverwind]

What version of go should I be using to match this project's go.sum file preferences

Latest go 1.13 should be fine. We're not on 1.14 yet.

This is LGTM, besides the odd checkbox rendering in those screenshots, but it's not related to this PR.

[silverwind]

Tried the PR. It does not seem to add the class for me:

[silverwind]

Nevermind, it does work with pandoc enabled, e.g.

[markup.markdown]
ENABLED         = true
FILE_EXTENSIONS = .md,.markdown
RENDER_COMMAND  = pandoc -f markdown -t html --katex

[cipherboy]

This is LGTM, besides the odd checkbox rendering in those screenshots, but it's not related to this PR.

Sorry, what's wrong with the checkboxes? If/when we get a class on the <ul> element or CSS4 selectors, we could fix the indentation to be consistent with GitHub (where a task list isn't indented and is more left-justified, unless it is nested obviously).

But the checkboxes themselves are correct. I'm on Fedora 31, under GNOME, and they match the system theme:

Tried the PR. It does not seem to add the class for me:

What are your rendering settings? As I mentioned above ("Styles task-lists to remove the bullets, when rendered with pandoc."), you have to use pandoc. My config is:

[markup.sanitizer]
ELEMENT    = span
ALLOW_ATTR = class
REGEXP     = ^(math\s*|inline\s*|display\s*){0,3}$

[markup.markdown]
ENABLED         = true
FILE_EXTENSIONS = .md,.markdown
RENDER_COMMAND  = bash /home/git/custom/conf/pandoc.sh

$ cat pandoc.sh
#!/bin/bash

export PANDOC_GITEA_PREFIX_SRC="$GITEA_PREFIX_SRC"
export PANDOC_GITEA_PREFIX_RAW="$GITEA_PREFIX_RAW"

pandoc -f markdown -t html -M PANDOC_GITEA_PREFIX_SRC="$GITEA_PREFIX_SRC" -M PANDOC_GITEA_PREFIX_RAW="$GITEA_PREFIX_RAW" --lua-filter=/home/git/custom/conf/pandoc.lua --katex

[silverwind]

GNOME

Ah, that's why. They just look a bit "unusual" to me 😉

Thanks for the pandoc info, I just switched to it.

[silverwind]

So to get this to work with the bluemonday sanitizer too, we need goldmark to add the class, right? Would you mind opening a goldmark issue on it?

[codecov-io]

Codecov Report

Merging #10668 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #10668      +/-   ##
==========================================
+ Coverage   43.61%   43.61%   +<.01%     
==========================================
  Files         588      588              
  Lines       82487    82490       +3     
==========================================
+ Hits        35973    35979       +6     
+ Misses      42053    42052       -1     
+ Partials     4461     4459       -2

Impacted Files	Coverage Δ
modules/markup/sanitizer.go	92.5% <100%> (+0.29%)	⬆️
modules/indexer/stats/db.go	50% <0%> (-9.38%)	⬇️
modules/queue/workerpool.go	55.87% <0%> (-2.14%)	⬇️
modules/log/event.go	64.61% <0%> (-1.03%)	⬇️
models/notification.go	63.88% <0%> (-0.84%)	⬇️
models/error.go	29.23% <0%> (+0.51%)	⬆️
services/pull/pull.go	35.88% <0%> (+1.17%)	⬆️
modules/git/command.go	89.56% <0%> (+2.6%)	⬆️
services/pull/check.go	53.04% <0%> (+4.87%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c5e5e...8e93fb1. Read the comment docs.

[cipherboy]

@silverwind Yes, I can file the issue when I get back. I was trying to figure out how to add the class earlier but I didn't get far enough.

[cipherboy]

@silverwind -- filed as yuin/goldmark#113.