Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki not routable if file name consists of spaces. #10732

Closed
2 of 7 tasks
furai opened this issue Mar 15, 2020 · 3 comments
Closed
2 of 7 tasks

Wiki not routable if file name consists of spaces. #10732

furai opened this issue Mar 15, 2020 · 3 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@furai
Copy link

furai commented Mar 15, 2020

  • Gitea version: 1.11.3
  • Git version: 2.25.1
  • Operating system: Ubuntu 18.04
  • Database:
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:
    Irrelevant

Description

Hey,

So I've encountered the issue few versions back where one of wiki files I had wasn't opening for me in the web browser. When I was clicking it - I was being redirected to the main page of the project's wiki. I left it for few months to sit there in hopes that it would get fixed eventually with some new version.

There were no error logs, at least not ones that would tell me right away what was wrong.
I've cloned the wiki by cloning the project-name.wiki.git repo. I've noticed then that the file in question was named something like some file name.md with spaces while all other files were hyphenated.
I've moved the file with git and added hyphens and it started working right away.

I'm not sure how this happened and when it stopped working as we weren't really checking out those wiki page in ages. Maybe it was imported from gogits.

Is there anything that can be done about it? Is this a problem with gitea or with my webserver?
What if someone creates a file manually in the wiki by committing it with name containing spaces - that would for sure break again. It's more convenient for me to edit wiki files directly in the repo, so I'm sure some people would like to do that as well.

Sorry for the lengthy message.

Cheers,
Furai

@furai
Copy link
Author

furai commented Mar 15, 2020

Actually, I've reproduced it on try.gitea.io
https://try.gitea.io/Furai/test-repository/wiki/_pages
Here you can see test and test test wiki pages. The latter one won't open.

@lunny lunny added the type/bug label Mar 16, 2020
@guillep2k
Copy link
Member

Just in case others get confused like me, this is not related to links inside the wiki content, but the page listing generated by Gitea.

@stale stale bot added the issue/stale label May 16, 2020
@techknowlogick techknowlogick added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels May 16, 2020
@go-gitea go-gitea deleted a comment from stale bot May 16, 2020
@wxiaoguang
Copy link
Contributor

It should have been fixed by #24143

But, you need to enter the titles in Web UI, Gitea has its own naming rules.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

No branches or pull requests

5 participants