Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent default for linkAction #10742

Merged
merged 1 commit into from Mar 16, 2020
Merged

Conversation

jolheiser
Copy link
Member

Should fix #10647
Should fix #10740

linkAction was sometimes losing the race to complete the POST before redirecting.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added this to the 1.12.0 milestone Mar 16, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 16, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 16, 2020
@jolheiser jolheiser merged commit c7f3d16 into go-gitea:master Mar 16, 2020
@jolheiser jolheiser deleted the stop-href branch March 16, 2020 21:13
jolheiser added a commit to jolheiser/gitea that referenced this pull request Mar 16, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Mar 16, 2020
guillep2k pushed a commit that referenced this pull request Mar 16, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to logout sometimes Bug: cant close milestone via ui
4 participants