Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude vendor dirs from git CRLF normalization #10911

Merged
merged 4 commits into from Apr 1, 2020

Conversation

silverwind
Copy link
Member

Should get rid of a few warnings like at the end of lint-backend like https://drone.gitea.io/go-gitea/gitea/23117/1/4.

Should get rid of a few warnings like at the end of `lint-backend` like
https://drone.gitea.io/go-gitea/gitea/23117/1/4
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 31, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2020
@6543
Copy link
Member

6543 commented Mar 31, 2020

@silverwind you have to make vendor and commit with new-old line endings

@silverwind
Copy link
Member Author

Done, let's see if it passes now without warnings.

@6543
Copy link
Member

6543 commented Mar 31, 2020

passed 👍

@silverwind
Copy link
Member Author

It passed and warnings are gone: https://drone.gitea.io/go-gitea/gitea/23122/1/4 🎉

@6543
Copy link
Member

6543 commented Mar 31, 2020

first 😎

@jolheiser jolheiser added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Mar 31, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone Mar 31, 2020
@codecov-io
Copy link

Codecov Report

Merging #10911 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10911      +/-   ##
==========================================
- Coverage   43.50%   43.48%   -0.02%     
==========================================
  Files         597      597              
  Lines       83945    83945              
==========================================
- Hits        36517    36501      -16     
- Misses      42914    42928      +14     
- Partials     4514     4516       +2     
Impacted Files Coverage Δ
services/pull/check.go 48.17% <0.00%> (-7.32%) ⬇️
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
modules/git/command.go 86.95% <0.00%> (-2.61%) ⬇️
services/pull/patch.go 61.93% <0.00%> (-2.59%) ⬇️
services/pull/temp_repo.go 29.05% <0.00%> (-2.57%) ⬇️
models/notification.go 61.68% <0.00%> (-0.79%) ⬇️
models/error.go 30.49% <0.00%> (-0.54%) ⬇️
modules/git/repo.go 48.11% <0.00%> (+0.83%) ⬆️
services/pull/pull.go 35.88% <0.00%> (+0.88%) ⬆️
models/unit.go 44.44% <0.00%> (+2.46%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d99ee2...35da12f. Read the comment docs.

@lafriks lafriks merged commit 848502d into go-gitea:master Apr 1, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants