Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxysupport for webhooks #1094

Closed
Schwobaland opened this issue Mar 1, 2017 · 3 comments
Closed

Proxysupport for webhooks #1094

Schwobaland opened this issue Mar 1, 2017 · 3 comments
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone
1.1.0

Comments

@Schwobaland
Copy link
Contributor

It should be possible to set a http-proxy in app.ini for webhooks.
There should be 3 properties:

  • HTTP_PROXY
  • HTTPS_PROXY
  • NO_PROXY

Alternatively env-variables could be used. This would ease the docker-deployment.
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 1, 2017
@lunny lunny added this to the 1.x.x milestone Mar 1, 2017
@tboerger
Copy link
Member

tboerger commented Mar 1, 2017

That should already work if your system provides these environment variables?

@Schwobaland
Copy link
Contributor Author

I tested on MacOS and Windows - and it doesn't work. I think, because of the proxy-property is always overwritten here. In default go-Transport-implementation ProxyFromEnvironment is used.

@Schwobaland Schwobaland mentioned this issue Mar 1, 2017
Merged
@lunny lunny modified the milestones: 1.1.0, 1.x.x Mar 2, 2017
@lunny
Copy link
Member

lunny commented Mar 2, 2017

resolved by #1096

@lunny lunny closed this as completed Mar 2, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@lunny @tboerger @Schwobaland