Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare two branches which has no base commit will result in 500 #1105

Closed
lunny opened this issue Mar 3, 2017 · 2 comments
Closed

Compare two branches which has no base commit will result in 500 #1105

lunny opened this issue Mar 3, 2017 · 2 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.8.0

Comments

@lunny
Copy link
Member

lunny commented Mar 3, 2017

It should show the error that the two branches cannot be compared.
git merge-base master gh-pages will return exit status 1 in https://github.com/go-gitea/git/blob/master/command.go#L50.
@lunny lunny added the type/bug label Mar 3, 2017
@lunny lunny added this to the 1.x.x milestone Mar 3, 2017
@stale
Copy link

stale bot commented Feb 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 17, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 23, 2019
@stale stale bot removed the issue/stale label Feb 23, 2019
@zeripath
Copy link
Contributor

Fixed by #6555 and its backport to 1.8 #6558

@lunny lunny modified the milestones: 1.x.x, 1.8.2, 1.8.0 May 28, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
2 participants
@lunny @zeripath