Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor Update: go-gitlab v0.22.1 -> v0.31.0 #11136

Merged
merged 3 commits into from
Apr 19, 2020
Merged

Vendor Update: go-gitlab v0.22.1 -> v0.31.0 #11136

merged 3 commits into from
Apr 19, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 19, 2020

as title

This was referenced Apr 19, 2020
Closed
Closed
@codecov-io
Copy link

Codecov Report

Merging #11136 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11136      +/-   ##
==========================================
- Coverage   43.27%   43.25%   -0.02%     
==========================================
  Files         601      601              
  Lines       85533    85531       -2     
==========================================
- Hits        37012    36997      -15     
- Misses      43951    43958       +7     
- Partials     4570     4576       +6
Impacted Files Coverage Δ
modules/migrations/gitlab.go 1.76% <0.00%> (+<0.01%) ⬆️
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
services/pull/pull.go 33.39% <0.00%> (-0.77%) ⬇️
modules/notification/webhook/webhook.go 39.61% <0.00%> (-0.59%) ⬇️
models/issue.go 51.48% <0.00%> (-0.47%) ⬇️
modules/git/repo.go 52.30% <0.00%> (+1.25%) ⬆️
models/unit.go 44.44% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c092eb...673024b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2020
@lafriks lafriks added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 19, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2020
@zeripath
Copy link
Contributor

It's somewhat of a shame the number of dependencies this causes to be duplicated.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2020
@zeripath zeripath merged commit 82dbb34 into go-gitea:master Apr 19, 2020
@lafriks lafriks deleted the vendor-go-gitlab branch April 19, 2020 20:26
@zeripath zeripath mentioned this pull request May 11, 2020
Closed
5 tasks
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Vendor Update: go-gitlab v0.22.1 -> v0.31.0 (go-gitea#11136)
99347c3 
* vendor update: go-gitlab to v0.31.0

* migrate client init to v0.31.0

* refactor
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@6543 @codecov-io @zeripath @lafriks @GiteaBot