Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip frontend build where unnecessary #11159

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Skip frontend build where unnecessary #11159

merged 1 commit into from
Apr 20, 2020

Conversation

silverwind
Copy link
Member

The testing pipelines and build-backend steps do not depend on frontend files, skip their build for them.

@silverwind
Skip frontend build where unnecessary
f5e823d 
The testing pipelines and build-backend steps do not depend on
frontend files, skip their build for them.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2020
@6543
Copy link
Member

6543 commented Apr 20, 2020

looking at CI it do not realy short time a lot but it's still a good idear

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2020
@zeripath zeripath added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 20, 2020
@zeripath zeripath added this to the 1.12.0 milestone Apr 20, 2020
@techknowlogick techknowlogick merged commit 50475ff into go-gitea:master Apr 20, 2020
@silverwind
Copy link
Member Author

You'll notice build steps in the integration pipelines gone down from 3-4m to around 1-2m.

@silverwind silverwind deleted the no-frontend branch April 20, 2020 20:54
@lunny
Copy link
Member

lunny commented Apr 21, 2020 •
edited

We could also create a docker image go-nodejs to speed up ci.

@silverwind
Copy link
Member Author

silverwind commented Apr 21, 2020 •
edited

Such a image would not gain much, Node.js installation is like 40s currently including curl and is only used in the release tasks after this PR. The bulk of the CI time is spent in the go linter, integration tests and various cross builds.

@guillep2k
Copy link
Member

@lunny Creating a docker image should solve our tmpfs problem!

@lunny
Copy link
Member

lunny commented Apr 22, 2020

@guillep2k https://gitea.com/gitea/build

@guillep2k
Copy link
Member

@guillep2k https://gitea.com/gitea/build

Superb! I'll try to play with this when I get some free time.

@silverwind
Copy link
Member Author

silverwind commented Apr 23, 2020 •
edited

My only worry about such an image is that it needs to be constantly be updated/rebuilt to track upstream changes. Do you plan on having any automation for that?

@silverwind silverwind mentioned this pull request Jun 8, 2020
Merged
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@silverwind
Skip frontend build where unnecessary (go-gitea#11159)
082b51c 
The testing pipelines and build-backend steps do not depend on
frontend files, skip their build for them.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@silverwind @6543 @lunny @guillep2k @zeripath @techknowlogick @GiteaBot