Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error pages translatable #11163

Merged
merged 6 commits into from
Apr 27, 2020
Merged

Make error pages translatable #11163

merged 6 commits into from
Apr 27, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 20, 2020

as title

6543
6543 commented Apr 20, 2020
View reviewed changes
options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
templates/status/500.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 20, 2020
zeripath
zeripath approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain this really gets us very fast but I guess it's a start

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2020
jaqra
jaqra reviewed Apr 21, 2020
View reviewed changes
Copy link
Contributor

@jaqra jaqra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed?

templates/status/500.tmpl Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Apr 26, 2020

@jaqra tested yes It need Safe

@davydov-vyacheslav
Copy link

@6543 Ain't I correct that error 500 should occur when server got exceptional cases? If so, it would be helpful, even to create a ticket, to have a stacktrace of the exception, wouldn't it?

@6543
Copy link
Member Author

6543 commented Apr 27, 2020

You will have if you set the gitea run mode to dev @davydov-vyacheslav

@6543
Copy link
Member Author

6543 commented Apr 27, 2020

need one review

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2020
@jolheiser jolheiser merged commit 41cebeb into go-gitea:master Apr 27, 2020
@jolheiser jolheiser changed the title [UI] make error pages translatable Make error pages translatable Apr 27, 2020
@6543 6543 deleted the translate-500-page branch April 28, 2020 02:20
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Make error pages translatable (go-gitea#11163)
5b86693 
* make error pages translatable

* dont translate ":"

* link need Safe
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k left review comments

@zeripath zeripath zeripath approved these changes

@jaqra jaqra jaqra approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@6543 @davydov-vyacheslav @zeripath @guillep2k @jaqra @GiteaBot @jolheiser