Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: updateLabel can updated not allowed fields #11242

Merged
merged 1 commit into from
Apr 28, 2020
Merged

BugFix: updateLabel can updated not allowed fields #11242

merged 1 commit into from
Apr 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 28, 2020

fix #11238

@lafriks lafriks added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Apr 28, 2020
lafriks
lafriks requested changes Apr 28, 2020
View reviewed changes
models/issue_label.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 28, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2020
lafriks
lafriks reviewed Apr 28, 2020
View reviewed changes
models/issue_label.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2020
@6543
Copy link
Member Author

6543 commented Apr 28, 2020 •
edited

ping lgtm

@techknowlogick techknowlogick merged commit 6b6f20b into go-gitea:master Apr 28, 2020
@6543 6543 deleted the fix-api-lables_11238 branch April 28, 2020 23:29
@guillep2k guillep2k added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 30, 2020
@guillep2k
Copy link
Member

@6543 I marked this as skip-changelog as I believe the bug was introduced in the 1.12-dev branch. Please correct me if I'm wrong.

@6543
Copy link
Member Author

6543 commented Apr 30, 2020

you are right ... :)

ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
BugFix: updateLabel can updated not allowed fields go-gitea#11242 (go…
a305369 
…-gitea#11242)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[bug] [api] issueGetLabels dont return correct responce
6 participants
@6543 @guillep2k @lafriks @zeripath @techknowlogick @GiteaBot