Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write fixed versions #1136

Closed
tboerger opened this issue Mar 7, 2017 · 8 comments
Closed

Write fixed versions #1136

tboerger opened this issue Mar 7, 2017 · 8 comments
Labels
issue/stale type/enhancement An improvement of existing functionality

Comments

@tboerger
Copy link
Member

tboerger commented Mar 7, 2017

Currently we are generating the version, that ends quite often in confusion so we should skip that and write the versions statically.

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Mar 7, 2017
@tboerger tboerger added this to the 1.2.0 milestone Mar 7, 2017
@lunny
Copy link
Member

lunny commented Mar 9, 2017

Git hash is very useful to find the problem. Fixed version cannot help us on that.

@appleboy
Copy link
Member

appleboy commented Mar 9, 2017

agree with @lunny.

@tboerger
Copy link
Member Author

tboerger commented Mar 9, 2017

We should just take the tag name + the last commit. This is something set by the CI. That's not so confusing like the crappy versioning that is currently used. I just say 1.0.0+388-g60db7ed5 instead of a proper version like 1.1.0+dev or 1.1.0+dev-60db7ed5 or 1.1.0+60db7ed5.

@strk
Copy link
Member

strk commented Mar 11, 2017

Isn't the currently generated version already using tag name + last commit ? I see 1.1.0+10-ge2b2fd6e on try.gitea.io, why do you think it's bad ?

@laplix
Copy link

laplix commented Mar 13, 2017

As a user, when I download and install a tag (release) version, I want to see that tag when I start the application.

A tag version does not change. So, if I file a bug against a tag version, you have all the necessary information.

When I look at my logs, I want to see the version I am running, not its hash tag. I don't want to come here trying to find the exact commit.

I am running a version, not a commit...

Thank you very much.

@lunny lunny modified the milestones: 1.x.x, 1.2.0 Apr 20, 2017
@stblassitude
Copy link
Contributor

I'm the package maintainer for the FreeBSD package of Gitea. The FreeBSD port downloads the respective release as a tar from Github; git never enters the picture. Right now, building the release 1.1.2 makes gitea info gitea show a version 1.0.0+dev (also in the web pages), which is confusing to users of the package.

My Go knowledge is not sufficient to suggest an implementation, but releases should integrate the actual release version instead of a fallback.

See also stblassitude/gitea-port#1

@lafriks
Copy link
Member

lafriks commented Jun 28, 2017

I think it should be just tag when release version and version+hash when built from master

@stale
Copy link

stale bot commented Feb 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 14, 2019
@lunny lunny removed this from the 1.x.x milestone Feb 15, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

7 participants