-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write fixed versions #1136
Comments
Git hash is very useful to find the problem. Fixed version cannot help us on that. |
agree with @lunny. |
We should just take the tag name + the last commit. This is something set by the CI. That's not so confusing like the crappy versioning that is currently used. I just say |
Isn't the currently generated version already using tag name + last commit ? I see |
As a user, when I download and install a tag (release) version, I want to see that tag when I start the application. A tag version does not change. So, if I file a bug against a tag version, you have all the necessary information. When I look at my logs, I want to see the version I am running, not its hash tag. I don't want to come here trying to find the exact commit. I am running a version, not a commit... Thank you very much. |
I'm the package maintainer for the FreeBSD package of Gitea. The FreeBSD port downloads the respective release as a tar from Github; git never enters the picture. Right now, building the release 1.1.2 makes My Go knowledge is not sufficient to suggest an implementation, but releases should integrate the actual release version instead of a fallback. See also stblassitude/gitea-port#1 |
I think it should be just tag when release version and version+hash when built from master |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
Currently we are generating the version, that ends quite often in confusion so we should skip that and write the versions statically.
The text was updated successfully, but these errors were encountered: