Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vendor] mssqldb: 2019-11-28 -> 2020-04-28 #11364

Merged
merged 3 commits into from
May 10, 2020
Merged

[Vendor] mssqldb: 2019-11-28 -> 2020-04-28 #11364

merged 3 commits into from
May 10, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 10, 2020

update go-mssqldb 2019-11-28 (1d7a30a10f73) -> 2020-04-28 (06a60b6afbbc)

it close eventualy #10258

@lafriks lafriks added this to the 1.12.0 milestone May 10, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #11364 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11364   +/-   ##
=======================================
  Coverage   43.83%   43.83%           
=======================================
  Files         613      613           
  Lines       87226    87229    +3     
=======================================
+ Hits        38235    38240    +5     
- Misses      44266    44268    +2     
+ Partials     4725     4721    -4
Impacted Files Coverage Δ
modules/setting/setting.go 45.53% <50.00%> (+0.25%) ⬆️
modules/indexer/stats/queue.go 62.50% <0.00%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0.00%> (-9.38%) ⬇️
modules/git/utils.go 65.67% <0.00%> (-4.48%) ⬇️
models/unit.go 41.97% <0.00%> (-2.47%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
modules/log/event.go 64.61% <0.00%> (-1.03%) ⬇️
routers/repo/view.go 35.96% <0.00%> (-0.68%) ⬇️
models/gpg_key.go 53.42% <0.00%> (-0.53%) ⬇️
models/issue.go 52.41% <0.00%> (+0.46%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da5e3fa...74201dc. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2020
@zeripath zeripath merged commit 6e23a1b into go-gitea:master May 10, 2020
@zeripath zeripath deleted the vendor_mssqldb branch May 10, 2020 17:42
@zeripath zeripath mentioned this pull request May 17, 2020
Merged
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
[Vendor] mssqldb: 2019-11-28 -> 2020-04-28 (go-gitea#11364)
47ebfca 
 update go-mssqldb 2019-11-28 (1d7a30a10f73) -> 2020-04-28 (06a60b6afbbc)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@6543 @codecov-io @lafriks @zeripath @GiteaBot