Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing card component to semantic.json #11394

Merged
merged 2 commits into from
May 13, 2020
Merged

Add missing card component to semantic.json #11394

merged 2 commits into from
May 13, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 12, 2020

Fixes missing .ui.card in Fomantic, introduced in #9561 and surfaced now due to #11244

We use this component on user page.

@jolheiser jolheiser added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI labels May 12, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone May 12, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 12, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 12, 2020
@lunny
Copy link
Member

lunny commented May 13, 2020

make L-G-T-M work.

@lunny lunny merged commit e9dc3bc into go-gitea:master May 13, 2020
@CirnoT CirnoT deleted the fomantic-card branch May 13, 2020 06:25
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 17, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @techknowlogick
Add missing card component to semantic.json (go-gitea#11394)
d6202f8 
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@CirnoT @lunny @mrsdizzie @zeripath @GiteaBot @jolheiser @techknowlogick