Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue templates directory #11450

Merged
merged 20 commits into from
Sep 11, 2020
Merged

Issue templates directory #11450

merged 20 commits into from
Sep 11, 2020

Conversation

jolheiser
Copy link
Member

@jolheiser jolheiser commented May 17, 2020 •
edited
Loading

Will eventually close #5488

To Do:

  • Implementation
    • Clean it up
  • API (At least for retrieving. Adding/changing/deleting could be the file API imo)
  • Documentation

Screenshot from 2020-06-18 23-08-14
Screenshot from 2020-05-16 22-41-24
Screenshot from 2020-06-18 23-07-55

@jolheiser
Issue templates
e96040a 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 17, 2020
@jolheiser jolheiser added this to the 1.13.0 milestone May 17, 2020
@jolheiser jolheiser changed the title [WIP] Issue templates directory Issue templates directory May 27, 2020
@6543
Copy link
Member

6543 commented Jun 8, 2020

please resolve confilct :)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 8, 2020
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Jun 8, 2020
@lafriks
Copy link
Member

lafriks commented Jun 8, 2020

Would be great to be able to specify also labels

@a1012112796
Copy link
Member

I have an idea about this feature. Maybe we can also allow repo to have more pull request templates which can be chosen on the new pull request page.

@jolheiser
Copy link
Member Author

I have an idea about this feature. Maybe we can also allow repo to have more pull request templates which can be chosen on the new pull request page.

That sounds interesting, but I would prefer that in a separate PR since it would likely need to be a little different.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2020 •
edited
Loading

Codecov Report

Merging #11450 into master will decrease coverage by 0.03%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11450      +/-   ##
==========================================
- Coverage   43.17%   43.14%   -0.04%     
==========================================
  Files         652      653       +1     
  Lines       72085    72252     +167     
==========================================
+ Hits        31125    31173      +48     
- Misses      35918    36026     +108     
- Partials     5042     5053      +11
Impacted Files Coverage Δ
modules/markup/markdown/meta.go 0.00% <0.00%> (ø)
modules/structs/issue.go 0.00% <0.00%> (ø)
routers/api/v1/repo/repo.go 61.81% <0.00%> (-0.35%) ⬇️
routers/repo/milestone.go 0.00% <0.00%> (ø)
modules/context/repo.go 55.66% <25.00%> (-2.55%) ⬇️
routers/repo/issue.go 36.73% <28.57%> (-0.40%) ⬇️
routers/api/v1/api.go 79.11% <100.00%> (+0.03%) ⬆️
routers/repo/compare.go 40.55% <100.00%> (ø)
routers/routes/routes.go 88.96% <100.00%> (+0.02%) ⬆️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1a651...a967205. Read the comment docs.

zeripath
zeripath reviewed Aug 24, 2020
View reviewed changes
routers/repo/issue.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Aug 24, 2020
View reviewed changes
routers/repo/issue.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Aug 24, 2020
View reviewed changes
routers/repo/issue.go Outdated Show resolved Hide resolved
@jolheiser
Suggestions
d9ac464 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Merge branch 'issue_template' of github.com:jolheiser/gitea into issu…
42d8759 
…e_template

# Conflicts:
#	routers/repo/milestone.go
@jolheiser
Merge branch 'master' of github.com:go-gitea/gitea into issue_template
ac14a37
@jolheiser
Extract metadata from legacy if possible
7611383 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 11, 2020
@techknowlogick techknowlogick merged commit 26c4a04 into go-gitea:master Sep 11, 2020
@jolheiser jolheiser deleted the issue_template branch September 11, 2020 14:49
@jolheiser jolheiser mentioned this pull request Sep 11, 2020
Closed
@lcnittl
Copy link

lcnittl commented Sep 23, 2020

Sorry for commenting here on this closed PR.

I am a bit confused: This is already in the docs, yet, it is a >=1.13 feature, right?

Thanks for clarifying!

@lunny
Copy link
Member

lunny commented Sep 23, 2020

@lcnittl Yes. The doc site will follow master branch.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CirnoT CirnoT CirnoT left review comments

@a1012112796 a1012112796 a1012112796 left review comments

@jaqra jaqra jaqra left review comments

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Please support the ISSUE_TEMPLATE directory