Fix the bug that the emoji does not disappear #11489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L0veSunshine
changed the title
|
Can you explain better what exactly does this fixes? |
GiteaBot
added
the
lgtm/need 2
React only one emoji and then unreact it. The emoji will not disappear. It should disappear. |
|
For anyone wondering, the issue is that attempting to unreact when there's only one emoji left has no effect on UI |
Yes, that's what this pr fix. |
L0veSunshine
changed the title
CirnoT
reviewed
May 19, 2020
lafriks
reviewed
May 19, 2020
Co-authored-by: Lauris BH <lauris@nix.lv>
lafriks
reviewed
May 19, 2020
Co-authored-by: Lauris BH <lauris@nix.lv>
lafriks
added
backport/v1.12
type/bug
topic/ui
CirnoT
approved these changes
May 19, 2020
CirnoT
approved these changes
May 19, 2020
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
May 20, 2020
GiteaBot
added
lgtm/done
lafriks
approved these changes
May 20, 2020
|
ping LG-TM |
|
@L0veSunshine please send backport to release/v1.12 :) |
techknowlogick
added a commit
that referenced
this pull request
May 22, 2020
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Fix the bug that the emoticon does not disappear * Update web_src/js/index.js Co-authored-by: Lauris BH <lauris@nix.lv> * Update web_src/js/index.js Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: zeripath <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11036
When you add one emoji here. and then cancel this emoji. The emoji will not disapper until you fresh the page.(This only occur when there is only one emoji)
This bug is on https://try.gitea.io/ and https://gitea.com/. You can have a try. Click here!