Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access table should store all explicit accesses to repository #11558

Open
CirnoT opened this issue May 22, 2020 · 4 comments
Open

access table should store all explicit accesses to repository #11558

CirnoT opened this issue May 22, 2020 · 4 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented

Comments

@CirnoT
Copy link
Contributor

CirnoT commented May 22, 2020

Currently it does not store explicit read access, even for private organizations or for restricted users.

This is because of

gitea/models/access.go

Lines 190 to 192 in 5789e60

if !repo.IsPrivate {
minMode = AccessModeWrite
}

The code was introduced with Gogs in 473e265

If removed, migration would be required to recalculate accesses for current teams.

@mrsdizzie
Copy link
Member

mrsdizzie commented May 22, 2020

This would be needed for proper issue assignment without having to walk through every team with access

@stale
Copy link

stale bot commented Jul 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 25, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented Jul 26, 2020

bad bot

@stale stale bot removed the issue/stale label Jul 26, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Oct 4, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Oct 5, 2020
@stale stale bot removed the issue/stale label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented
Projects
None yet
Development

No branches or pull requests

4 participants