Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serviceworker output file and misc improvements #11562

Merged
merged 7 commits into from
May 24, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 22, 2020

  • Fix output file location for production build
  • Cache more asset types: fonts and worker variants
  • Parallelize a few tasks during initalization
  • Only invalidate caches starting with our prefix
  • Remove public/serviceworker.js before building
  • Remove font preloads, they cause strange cors issues
  • Misc eslint config adjustments

This contains a important bugfix (the file location) so should be labeled as bug and backported to 1.12.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 22, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone May 22, 2020
- Fix output file location for production build
- Cache more asset types: fonts and worker variants
- Parallelize a few tasks during initalization
- Only invalidate caches starting with our prefix
- Remove public/serviceworker.js before building
- Remove font preloads, they cause strange cors issues
- Misc eslint config adjustments
@silverwind silverwind changed the title Serviceworker tweaks Fix serviceworker output file and misc improvements May 22, 2020
@silverwind
Copy link
Member Author

silverwind commented May 23, 2020

Looking forward to landing this as the webpack fix is critical.

Issue is that chunk.id returns the chunk name in a dev build but in a prod build it returns numbers which makes serviceworker.js output to the wrong directory and the serviceworker not registering.

I can split out the webpack fix to a separate PR if it's really needed.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2020
@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit 3761bdb into go-gitea:master May 24, 2020
@zeripath
Copy link
Contributor

please send backport

silverwind added a commit to silverwind/gitea that referenced this pull request May 24, 2020
* Fix serviceworker output file and misc improvements

- Fix output file location for production build
- Cache more asset types: fonts and worker variants
- Parallelize a few tasks during initalization
- Only invalidate caches starting with our prefix
- Remove public/serviceworker.js before building
- Remove font preloads, they cause strange cors issues
- Misc eslint config adjustments

* remove webpack output files on watch-frontend
lafriks pushed a commit that referenced this pull request May 24, 2020
* Fix serviceworker output file and misc improvements

- Fix output file location for production build
- Cache more asset types: fonts and worker variants
- Parallelize a few tasks during initalization
- Only invalidate caches starting with our prefix
- Remove public/serviceworker.js before building
- Remove font preloads, they cause strange cors issues
- Misc eslint config adjustments

* remove webpack output files on watch-frontend
@lafriks lafriks added the backport/done All backports for this PR have been created label May 24, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Fix serviceworker output file and misc improvements

- Fix output file location for production build
- Cache more asset types: fonts and worker variants
- Parallelize a few tasks during initalization
- Only invalidate caches starting with our prefix
- Remove public/serviceworker.js before building
- Remove font preloads, they cause strange cors issues
- Misc eslint config adjustments

* remove webpack output files on watch-frontend
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants