rework eslint config #11615
Merged
rework eslint config #11615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
force-pushed
the
eslint-config-update
branch
2 times, most recently
from
b73a3a7
to
09035a3
Compare
zeripath
reviewed
May 24, 2020
GiteaBot
added
the
lgtm/need 2
techknowlogick
added
the
type/refactoring
zeripath
reviewed
May 25, 2020
|
I can undo the config/dependency changes if requested. There is a certain benefit of depending on a shared config because much less work is required to update the config, even thought we need to disable 20-something rules that are too opinionated in the airbnb config. |
zeripath
approved these changes
May 27, 2020
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
- use explicit config that only enables rules - upgrade eslint to 7.1.0 - add new plugins with selected rules enabled - fix discovered issues, remove global wipPrefixes
|
Updated eslint and plugins again. |
silverwind
force-pushed
the
eslint-config-update
branch
from
7b06e85
to
baa2932
Compare
|
Rebased and fixed one more new violation (detected by |
lafriks
approved these changes
Jun 9, 2020
|
ping LG-TM |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* rework eslint config - use explicit config that only enables rules - upgrade eslint to 7.1.0 - add new plugins with selected rules enabled - fix discovered issues, remove global wipPrefixes * remove if * undo template change * add disabled rules as well for easier config updating * add missing disabled rule * update eslint and plugins * fix new violation * remove deprecated rules Co-authored-by: Lauris BH <lauris@nix.lv>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules are mostly based on my config. Two of the plugins still don't specify eslint 7 compatibilty, but I think it's no issue, they do work fine.