Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced labels with priority #11669

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 29, 2020

Adds support to define label sets in yaml files

screenshot

TODO:

  • Update UI
  • Add tests
  • Add issue/PR sort option
  • Add user/org/repo? preference option to sort by priority by default or not

@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 29, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 29, 2020
options/label/Advanced.yaml Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 29, 2020
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General note, anywhere that checks for .yaml should probably also check for .yml

@stale
Copy link

stale bot commented Jul 29, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 29, 2020
@6543
Copy link
Member

6543 commented Jul 29, 2020

ping

@stale stale bot removed the issue/stale label Jul 29, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 4, 2020
@lunny lunny modified the milestones: 1.13.0, 1.14.0 Sep 1, 2020
@lunny lunny modified the milestones: 1.14.0, 1.15.0 Jan 27, 2021
@techknowlogick techknowlogick modified the milestones: 1.15.0, 1.16.0 Jun 15, 2021
@lafriks lafriks mentioned this pull request Jul 14, 2021
@lunny lunny removed this from the 1.16.0 milestone Nov 9, 2021
@lafriks lafriks force-pushed the feat/priority branch 5 times, most recently from 58db236 to c20e06a Compare December 6, 2021 07:53
@lafriks lafriks mentioned this pull request Jan 21, 2022
@lafriks lafriks mentioned this pull request Mar 23, 2022
@lafriks lafriks force-pushed the feat/priority branch 2 times, most recently from 76f8ef4 to 53e7edb Compare August 29, 2022 11:27
lafriks added a commit that referenced this pull request Mar 1, 2023
Extract from #11669 and enhancement to #22585 to support exclusive
scoped labels in label templates

* Move label template functionality to label module
* Fix handling of color codes
* Add Advanced label template
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 1, 2023
Extract from go-gitea#11669 and enhancement to go-gitea#22585 to support exclusive
scoped labels in label templates

* Move label template functionality to label module
* Fix handling of color codes
* Add Advanced label template
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Mar 1, 2023
Extract from go-gitea#11669 and enhancement to go-gitea#22585 to support exclusive
scoped labels in label templates

* Move label template functionality to label module
* Fix handling of color codes
* Add Advanced label template
techknowlogick pushed a commit that referenced this pull request Mar 2, 2023
Backport #22976

Extract from #11669 and enhancement to #22585 to support exclusive
scoped labels in label templates

* Move label template functionality to label module
* Fix handling of color codes
* Add Advanced label template

Co-authored-by: Lauris BH <lauris@nix.lv>
@yardenshoham
Copy link
Member

This is in progress for a while now, I'm closing it to avoid stale pull requests. Please reopen when it's ready for review.

@lafriks
Copy link
Member Author

lafriks commented May 2, 2023

I will work on it ;)

@lafriks lafriks reopened this May 2, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 2, 2023
* Calculate issue priority when adding/removing labels
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 2, 2023
@lunny lunny reopened this May 23, 2023
@lafriks lafriks mentioned this pull request Jun 1, 2023
9 tasks
@puni9869
Copy link
Member

puni9869 commented Sep 1, 2023

Scoped labels are good for defining priority.

@tgy
Copy link

tgy commented Sep 7, 2023

@lafriks are you still working on this? this would be an awesome feature!

@puni9869 could you detail how you solve this with scoped label? say e.g. p/1 p/2 p/3 would be your scoped priority labels, how do you know the issues will be sorted based on this? (p/1 should be the first priority, then p/2, then p/3 etc.)

@lafriks
Copy link
Member Author

lafriks commented Sep 7, 2023

Yes, slowly but working, few things need to finish

@puni9869
Copy link
Member

puni9869 commented Sep 7, 2023

@lafriks are you still working on this? this would be an awesome feature!

@puni9869 could you detail how you solve this with scoped label? say e.g. p/1 p/2 p/3 would be your scoped priority labels, how do you know the issues will be sorted based on this? (p/1 should be the first priority, then p/2, then p/3 etc.)

I will share soon on it. Its in my TODO.

@lafriks
Copy link
Member Author

lafriks commented Sep 7, 2023

Each label you can set priority, it could be either scoped or not and issue priority will be calculated form labels that has priority set there will be 4 priority levels you can assign to label (critical, high, medium, low)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants