Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Note] Refactor routers/api/v1/repo/EditPullRequest #11792

Open
6543 opened this issue Jun 7, 2020 · 2 comments
Open

[Note] Refactor routers/api/v1/repo/EditPullRequest #11792

6543 opened this issue Jun 7, 2020 · 2 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented modifies/api This PR adds API routes or modifies them type/refactoring Existing code has been cleaned up. There should be no new functionality.

Comments

@6543
Copy link
Member

6543 commented Jun 7, 2020

at the moment group of attributes are changed in a barch and stop prosessing when an error ocure:

  • check if request is valid bevore changing anything
  • change all things in one DB session

came up in #11666

@blaggacao
Copy link

/cc @zeripath

@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 8, 2020
@zeripath zeripath added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 8, 2020
@stale stale bot removed the issue/stale label Aug 8, 2020
@6543 6543 added modifies/api This PR adds API routes or modifies them type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented modifies/api This PR adds API routes or modifies them type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

No branches or pull requests

3 participants