Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align show/hide outdated button on code review block #11932

Merged
merged 3 commits into from Jun 18, 2020
Merged

Align show/hide outdated button on code review block #11932

merged 3 commits into from Jun 18, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jun 17, 2020

Before:
chrome_2020-06-17_20-08-42

After:
chrome_2020-06-17_20-08-24

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 17, 2020
@silverwind
Copy link
Member

Should fix the monospaced font in review stuff eventually. I think it's completely unintended.

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Jun 17, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit 6c38f37 into go-gitea:master Jun 18, 2020
@techknowlogick
Copy link
Member

@CirnoT please send backport :)

@CirnoT CirnoT deleted the show-outdated_review branch June 18, 2020 06:48
CirnoT added a commit to CirnoT/gitea that referenced this pull request Jun 18, 2020
@CirnoT
Align show/hide outdated button on code review block (go-gitea#11932)
31fd8d9 
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
(cherry picked from commit 6c38f37)
@CirnoT CirnoT mentioned this pull request Jun 18, 2020
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Jun 18, 2020
lunny pushed a commit that referenced this pull request Jun 18, 2020
@CirnoT
Align show/hide outdated button on code review block (#11932) (#11944)
d534007 
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
(cherry picked from commit 6c38f37)
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @lafriks @techknowlogick
Align show/hide outdated button on code review block (go-gitea#11932)
6b2f705 
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@CirnoT @silverwind @techknowlogick @lafriks @GiteaBot