Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web editor indentation #11

Closed
joubertredrat opened this issue Nov 2, 2016 · 6 comments
Closed

Web editor indentation #11

joubertredrat opened this issue Nov 2, 2016 · 6 comments
Labels
issue/stale topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@joubertredrat
Copy link
Contributor

joubertredrat commented Nov 2, 2016

Now with web editor working fine, I think that is necessary to set configurations by default or defined by user for better experience with web editor.

On PHP, javascript and I think that Go (Unknwon talk me if I'm wrong) we prefer 4 spaces indentation.
However, HTML and CSS developers normally prefer 2 spaces indentation. Have cases on other developers prefer tabulation instead spaces.

Because this I think that web editor can be configurable, one good example for this is on Bitbucket, you can set options in own editor.

screenshot-bitbucket org 2016-09-06 13-25-57

Or this configuration can be defined on user settings on only on admin area.

What you think guys?

Reference: gogs/gogs#3460 (comment)
Reference: gogs/gogs#3610

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/38896626-web-editor-indentation?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).
@metalmatze
Copy link
Contributor

gofmt uses tabs and one tab equals 8 spaces.
https://golang.org/cmd/gofmt/
I really like the idea to make it customizable!

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@tboerger tboerger added this to the 1.x.x milestone Nov 3, 2016
@tboerger tboerger added the topic/ui Change the appearance of the Gitea UI label Nov 3, 2016
@silverwind
Copy link
Member

silverwind commented Nov 18, 2016

Customization options could be saved to localStorage on the client, but the defaults should come from the repository's .editorconfig.

@pgaskin
Copy link
Contributor

pgaskin commented Mar 15, 2017

What would be the scope of the saved changes? The repo? The filetype? The filepath? The session?

@silverwind
Copy link
Member

I'd say per-user options are sufficient. If you want finer control, you're better of placing a .editorconfig in the repo.

@stale
Copy link

stale bot commented Feb 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 4, 2019
@stale
Copy link

stale bot commented Feb 19, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Feb 19, 2019
@lafriks lafriks removed this from the 1.x.x milestone Feb 19, 2019
6543 pushed a commit to 6543-forks/gitea that referenced this issue May 5, 2020
* Fixes error 500 when trying to create a User or na Organization project

* Made the issue sidebar template consistent with the mew issue sidebar

Moved the Project under the Milestone

* Fix for create a User or na Organization project showing

* Revents 7eb8846

* Revert "Fix for create a User or na Organization project showing"

This reverts commit 7fc0ac9.

* Removes User and Organization Projects from the frontend
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

6 participants