Fix emoji detection in certain cases #12320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous tests weren't complicated enough so there were some situations where emojis were't detected properly. Find the earliest occurance in addition to checking for the longest combination. Fixes go-gitea#12312
lafriks
approved these changes
Jul 24, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
added
the
skip-changelog
|
Looking good now with my other PR together:
The missed |
silverwind
approved these changes
Jul 25, 2020
GiteaBot
added
lgtm/done
|
Could be 1.12 backport too I think |
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Jul 25, 2020
* Fix emoji detection certain cases Previous tests weren't complicated enough so there were some situations where emojis were't detected properly. Find the earliest occurance in addition to checking for the longest combination. Fixes go-gitea#12312 * ok spell bot Co-authored-by: Lauris BH <lauris@nix.lv>
|
#12327 for backport of both PRs. |
techknowlogick
added
backport/done
techknowlogick
pushed a commit
that referenced
this pull request
Jul 25, 2020
* Fix emoji detection in certain cases (#12320) * Fix emoji detection certain cases Previous tests weren't complicated enough so there were some situations where emojis were't detected properly. Find the earliest occurance in addition to checking for the longest combination. Fixes #12312 * ok spell bot Co-authored-by: Lauris BH <lauris@nix.lv> * Reduce emoji size (#12317) * Reduce emoji size Rendering should now pretty much match GitHub with 1.25em. I verified that emojis don't increase the line height and removed unecessary size overrides because now all emojis should appear similar in relation to the font size. * fix reaction hover Co-authored-by: mrsdizzie <info@mrsdizzie.com> Co-authored-by: Lauris BH <lauris@nix.lv>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous tests weren't complicated enough so there were some situations where emojis were't detected properly. Find the earliest occurrence in addition to checking for the longest combination.
Fixes #12312 (the bug portion)