Add note to README about make parallelism #12378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative to go-gitea#12367
zeripath
approved these changes
Jul 30, 2020
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Jul 30, 2020
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
techknowlogick
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #12367
Parallelism will screw our build in two ways:
generateandfrontendat the same time which breaks the public bindata$(EXECUTABLE)andgenerateat the same time which breaks all bindataIt could be solved by adding a proper dependency chain that enforces serialization but that would introduce a frontend/Node.js dependency on the backend chain which we want to avoid for users that don't have Node installed (e.g. building off the
srctarballs). I think it's best to not intermingle backend/frontend dependency chains and just recommend not enabling parallelism as there is nothing that can run in parallel in the regular build (but not forbid it either so useful things likemake -j2 watch-backend watch frontendwill still work).