Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect full references to issues and pulls in commit messages #12399

Merged
merged 8 commits into from
Aug 6, 2020
Merged

Detect full references to issues and pulls in commit messages #12399

merged 8 commits into from
Aug 6, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Aug 1, 2020

Fix #10269

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Detect full references to issues and pulls in commit messages
841918b 
Fix go-gitea#10269

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the type/enhancement An improvement of existing functionality label Aug 1, 2020
@zeripath zeripath added this to the 1.13.0 milestone Aug 1, 2020
@silverwind
Copy link
Member

Did not seem to work with:

git commit --allow-empty -m 'xxx - fixes: http://localhost:3500/test/test/issues/1'

but this did:

git commit --allow-empty -m 'xxx - fixes: #1'

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 1, 2020
@zeripath
Really close the issue
e3155b2 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Copy link
Contributor Author

zeripath commented Aug 1, 2020

Sorry @silverwind looks like that was an initially failed attempt. The problem was that I was looking in the wrong place - I'll leave the other fix in place though.

silverwind
silverwind approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Some kind of test for this may be good to have, but not required.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 4, 2020
@lunny
Copy link
Member

lunny commented Aug 5, 2020

I think tests are necessary.

@zeripath
Merge remote-tracking branch 'origin/master' into fix-10269-allow-lin…
791a0b6 
…ks-references
@zeripath
add some testcases
25f3c41 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Copy link
Contributor Author

zeripath commented Aug 5, 2020

done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 6, 2020
@zeripath
Copy link
Contributor Author

zeripath commented Aug 6, 2020

make lg-tm work

@zeripath zeripath merged commit e770c2b into go-gitea:master Aug 6, 2020
@zeripath zeripath deleted the fix-10269-allow-links-references branch August 6, 2020 19:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 left review comments

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Issue does not close via Fixes: <url>
5 participants
@zeripath @silverwind @lunny @6543 @GiteaBot