Customize ShortSha length in templates [master]

[gabyx]

It would be nice if we could somehow customize the length of the ShortSha in the templates over app.ini or somehow else:

Such that all GUI related SHA hashes have some predefined length. In our setting, we need a length of 12.

The relevant code is here.

gitea/modules/base/tool.go

Line 57 in 0e24af6

return TruncateString(sha1, 10)

Templates use

{{ShortSha .LatestCommit.ID.String}}

[bagasme]

@gabyx why did you need 12-length shortsha? 100k+ commits?

[6543]

I think the easyest way to go is with app.ini setting

[zeripath]

it'd be good if we could somehow just have this as a per repo setting - or even have git do this I guess the question is how expensive is it to generate these shortsha lengths?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[gabyx]

Method without git config:

• Just store the option somewhere global app.ini or per repo .gitea/....

Method git config:

First good solution would be to read git config core.abbrev and use this to shorten the commit sha. However you dont want to read this config value for every conversion. Also its unsafe, since we dont know if gitea relies on this setting for parsing stuff from the log or so...

So the user can define on the server a git config --global core.abbrev.
Later solution could be to add this to the app.ini for a global invocation of git config --set --global core.abbrev XXX at startup.