Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up licenses.txt build during development, add additionalModules #12510

Merged
merged 3 commits into from Aug 22, 2020
Merged

Speed up licenses.txt build during development, add additionalModules #12510

merged 3 commits into from Aug 22, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Aug 17, 2020 •
edited

  • Emit static string for licenses.txt during development for faster builds
  • Manually add @primer/octicons to licenses.txt because it's never directly imported.

@silverwind
Speed up licenses.txt build during development, add additionalModules
39438d6 
- Emit static string for licenses.txt during development for faster builds
- Manually add @primer/octicons to licenses.txt because it's never
  directy imported.
@silverwind silverwind changed the title Disable licenses.txt build during development Speed up licenses.txt build during development, add additionalModules Aug 17, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020 •
edited

Codecov Report

Merging #12510 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12510      +/-   ##
==========================================
- Coverage   43.54%   43.51%   -0.04%     
==========================================
  Files         637      637              
  Lines       70825    70825              
==========================================
- Hits        30844    30821      -23     
- Misses      34978    35008      +30     
+ Partials     5003     4996       -7
Impacted Files Coverage Δ
services/pull/check.go 31.53% <0.00%> (-18.47%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (-2.05%) ⬇️
models/pull.go 54.54% <0.00%> (-0.63%) ⬇️
models/error.go 34.81% <0.00%> (-0.52%) ⬇️
routers/repo/view.go 37.98% <0.00%> (+0.64%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/log/event.go 59.43% <0.00%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b9e7cf...39438d6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 9b804f4 into go-gitea:master Aug 22, 2020
@silverwind silverwind deleted the licenseadd branch August 22, 2020 05:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@CirnoT CirnoT CirnoT approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@silverwind @codecov-commenter @techknowlogick @lafriks @CirnoT @GiteaBot