Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show outdated comments in pull request #12523

Closed
2 of 7 tasks
melmus opened this issue Aug 18, 2020 · 9 comments · Fixed by #13148
Closed
2 of 7 tasks

Show outdated comments in pull request #12523

melmus opened this issue Aug 18, 2020 · 9 comments · Fixed by #13148
Labels
good first issue Likely to be an easy fix hacktoberfest

Comments

@melmus
Copy link

melmus commented Aug 18, 2020

  • Gitea version (or commit ref):
    1.13.0+dev-295-g16980d13c

  • Git version:
    2.17.1

  • Operating system:
    Ubuntu 18.04.3 LTS

  • Database (use [x]):

    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:

    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

If I get comment and make change, this comment will close, and I need to click button "Show outdated" for see it. It is a problem. I must see the comments.

Screenshots

1
2

@lafriks
Copy link
Member

lafriks commented Aug 19, 2020

It becomes outdated if someone pushes commit that changes commented line. It is intentional so that it could be easy to see review comments that still needs to be fixed and that are already fixed. You still can see comment by clicking on Show outdated

@melmus
Copy link
Author

melmus commented Aug 20, 2020

@lafriks, Yes, you are right. But comment does not resolved. Clicking the button every time is not comfortable.

@deptyped
Copy link

The button to make the selected outdated comment unresolved and active again will be useful.

@davidglezz
Copy link

davidglezz commented Aug 31, 2020

It would be useful to show if it is resolved or not without having to click "show outdated" btn
Like this:
image

And/Or, if it is not resolved, show even though it is outdated

@lakostin
Copy link

i agree, its very annoying when all the comments are hidden!!! i can decide by myself if the comment to the necessary line is outdated or not!

@zeripath
Copy link
Contributor

This would be a very easy pr

@lakostin
Copy link

This would be a very easy pr

is there any way to force its creation?

@techknowlogick
Copy link
Member

is there any way to force its creation?

start a bounty?

@lakostin
Copy link

is there any way to force its creation?

start a bounty?

you're welcome

@zeripath zeripath added good first issue Likely to be an easy fix hacktoberfest labels Oct 1, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Likely to be an easy fix hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants