Multiple permissions fixes for projects

[wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf]

As communicated in discord/develop, here's this little PR.
I believe there is no reason to show the 'New Project board' button for users that are not signed in.
Before:

After:

[codecov-commenter]

Codecov Report

Merging #12547 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #12547      +/-   ##
==========================================
- Coverage   43.45%   43.44%   -0.02%     
==========================================
  Files         643      643              
  Lines       71144    71155      +11     
==========================================
- Hits        30919    30912       -7     
- Misses      35218    35233      +15     
- Partials     5007     5010       +3     

Impacted Files	Coverage Δ
routers/repo/projects.go	13.19% <18.18%> (+0.21%)	⬆️
routers/routes/routes.go	88.92% <100.00%> (+0.02%)	⬆️
modules/indexer/stats/db.go	52.17% <0.00%> (-17.40%)	⬇️
modules/git/utils.go	73.77% <0.00%> (-3.28%)	⬇️
modules/log/event.go	57.54% <0.00%> (-1.89%)	⬇️
modules/git/repo.go	49.23% <0.00%> (-0.51%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a048489...465dadf. Read the comment docs.

[zeripath]

This is not the correct test - we should only show the button if the user can create project boards

[wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf]

This is not the correct test - we should only show the button if the user can create project boards

This should now be addressed by the latest changes.
Button is not shown for unauthorized users nor if the repo is archived.

[wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf]

Only show this dropdown menu to authorized users (same as the button).
as per f60df0d

[silverwind]

This kind of screams for a CanCreateProject imho 😉

[wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf]

This kind of screams for a CanCreateProject imho wink

Yeah, a similar thought also appeared in the discord. I am not sure how to do that, though. :(

[lafriks]

adding new ctx variable is an option:

gitea/routers/repo/projects.go

Line 292 in 4027c5d

ctx.Data["PageIsProjects"] = true

[silverwind]

Ideally it would be a utility function somewhere in the project-related files which is then called to set the template variable on pages that render that template. That way, it can be re-used everywhere.

[wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf]

Ideally it would be a utility function somewhere in the project-related files which is then called to set the template variable on pages that render that template. That way, it can be re-used everywhere.

I may try to hack something together 🚀

[lunny]

I think we have a new unit named Project. Then those who have write permission of unit Project could edit and delete the board.

[zeripath]

I've taken the liberty to do the fixes.

[wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf]

I've taken the liberty to do the fixes.

From what I can gather it looks great, thank you!

[wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf]

Cheers folks! 🚀 🚀 🚀