Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable password complexity check default #12557

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

mrsdizzie
Copy link
Member

@mrsdizzie mrsdizzie commented Aug 21, 2020

These features enourange bad passwords/are annoying for people using better password methods, and at minimum we shouldn't force that as a default for obvious reasons. Disable any default check to avoid regular complaints.

Close #12284

These features enourange bad passwords/are annoying for people using better password methods, and at minimum we shouldn't force that as a default for obvious reasons. Disable any default check to avoid regular complaints.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 21, 2020
@zeripath zeripath added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Aug 21, 2020
@zeripath zeripath added this to the 1.13.0 milestone Aug 21, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12557 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12557      +/-   ##
==========================================
- Coverage   43.45%   43.44%   -0.02%     
==========================================
  Files         643      643              
  Lines       71142    71145       +3     
==========================================
- Hits        30914    30907       -7     
- Misses      35222    35228       +6     
- Partials     5006     5010       +4     
Impacted Files Coverage Δ
modules/setting/setting.go 46.91% <100.00%> (+1.11%) ⬆️
modules/util/remove.go 65.38% <0.00%> (-15.39%) ⬇️
services/pull/update.go 51.92% <0.00%> (-5.77%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-1.02%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-0.70%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2cf23...b3ddafc. Read the comment docs.

@techknowlogick techknowlogick merged commit fb70b5d into go-gitea:master Aug 21, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password complexity harms memorability
6 participants