Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-built hugo binary in release step #12725

Merged
merged 3 commits into from
Sep 5, 2020

Conversation

techknowlogick
Copy link
Member

this should also fix issue in release step re: hugo

@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 5, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2020

Codecov Report

Merging #12725 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12725      +/-   ##
==========================================
+ Coverage   43.39%   43.42%   +0.03%     
==========================================
  Files         647      647              
  Lines       71487    71487              
==========================================
+ Hits        31023    31045      +22     
+ Misses      35444    35428      -16     
+ Partials     5020     5014       -6     
Impacted Files Coverage Δ
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
modules/indexer/stats/db.go 60.86% <0.00%> (ø)
models/error.go 35.66% <0.00%> (+0.34%) ⬆️
services/pull/pull.go 42.03% <0.00%> (+0.46%) ⬆️
models/gpg_key.go 55.40% <0.00%> (+0.58%) ⬆️
models/notification.go 67.04% <0.00%> (+0.91%) ⬆️
modules/notification/ui/ui.go 83.33% <0.00%> (+2.77%) ⬆️
modules/log/event.go 59.43% <0.00%> (+2.83%) ⬆️
modules/notification/mail/mail.go 37.93% <0.00%> (+3.44%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b51bd7f...0a32b87. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2020
@zeripath
Copy link
Contributor

zeripath commented Sep 5, 2020

Agreed we're building Gitea not Hugo!

@zeripath zeripath merged commit bab1204 into go-gitea:master Sep 5, 2020
@silverwind
Copy link
Member

Probably should add some logic to support Mac/Windows.

@techknowlogick techknowlogick deleted the fix-hugo-release branch September 10, 2020 15:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants