Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing k8s contrib file #12761

Merged

Conversation

techknowlogick
Copy link
Member

We now have a helm chart that users should use instead

We now have a helm chart that users should use instead
@codecov-commenter
Copy link

Codecov Report

Merging #12761 into master will decrease coverage by 0.00%.
The diff coverage is 37.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12761      +/-   ##
==========================================
- Coverage   43.30%   43.30%   -0.01%     
==========================================
  Files         648      647       -1     
  Lines       71765    71799      +34     
==========================================
+ Hits        31077    31091      +14     
- Misses      35657    35672      +15     
- Partials     5031     5036       +5     
Impacted Files Coverage Δ
modules/indexer/code/elastic_search.go 0.00% <0.00%> (ø)
modules/indexer/code/indexer.go 35.22% <36.47%> (-0.95%) ⬇️
modules/queue/queue.go 32.25% <47.61%> (+7.86%) ⬆️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
modules/git/repo.go 49.74% <0.00%> (-0.51%) ⬇️
cmd/dump.go 1.03% <0.00%> (-0.02%) ⬇️
models/issue_comment.go 53.90% <0.00%> (+0.15%) ⬆️
models/models.go 57.94% <0.00%> (+0.50%) ⬆️
models/error.go 35.32% <0.00%> (+0.51%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226aef7...98b1567. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 7, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 8, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 8, 2020
@techknowlogick techknowlogick merged commit e4b3f35 into go-gitea:master Sep 8, 2020
@techknowlogick techknowlogick deleted the techknowlogick-patch-2 branch September 8, 2020 03:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants