Allow extended config on cron settings #12939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#12934 Signed-off-by: Andrew Thornton <art27@cantab.net>
7 tasks
lafriks
reviewed
Sep 24, 2020
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
approved these changes
Sep 24, 2020
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #12939 +/- ##
=======================================
Coverage 42.82% 42.82%
=======================================
Files 661 661
Lines 72977 72986 +9
=======================================
+ Hits 31250 31254 +4
- Misses 36658 36660 +2
- Partials 5069 5072 +3
Continue to review full report at Codecov.
|
olexiyb
reviewed
Sep 25, 2020
| // GetCronSettings maps the cron subsection to the provided config | ||
| func GetCronSettings(name string, config interface{}) (interface{}, error) { | ||
| err := Cfg.Section("cron." + name).MapTo(config) | ||
| return config, err | ||
| if err := Cfg.Section("cron." + name).MapTo(config); err != nil { |
There was a problem hiding this comment.
I have 0 experience in Go, but it was hard for me to read this line. I did some research and potentially this may help to avoid such init statements in if with return inside
https://golang.org/doc/effective_go.html#if
In the Go libraries, you'll find that when an if statement doesn't flow into the next statement—that is, the body ends in break, continue, goto, or return—the unnecessary else is omitted.
f, err := os.Open(name)
if err != nil {
return err
}
codeUsing(f)
More to read
https://www.calhoun.io/one-liner-if-statements-with-errors/
lunny
approved these changes
Sep 25, 2020
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Sep 25, 2020
Backport go-gitea#12939 Fix go-gitea#12934 Signed-off-by: Andrew Thornton <art27@cantab.net>
jolheiser
pushed a commit
that referenced
this pull request
Sep 25, 2020
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround odd behaviour in go-ini whereby an embedded field does not get the values from the same section.
Fix #12934
Signed-off-by: Andrew Thornton art27@cantab.net