Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog v1.13.0-RC1 #13142

Merged
merged 18 commits into from Oct 14, 2020
Merged

Changelog v1.13.0-RC1 #13142

merged 18 commits into from Oct 14, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 14, 2020

as title

@6543 6543 added the pr/wip This PR is not ready for review label Oct 14, 2020
@6543 6543 added this to the 1.13.0 milestone Oct 14, 2020
@6543 6543 added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 14, 2020
@lunny
Copy link
Member

lunny commented Oct 14, 2020

rc1

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2020
@6543 6543 changed the title Changelog v1.13.0 Changelog v1.13.0-rc1 Oct 14, 2020
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@6543 6543 changed the title Changelog v1.13.0-rc1 Changelog v1.13.0-RC1 Oct 14, 2020
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 14, 2020 •
edited

Codecov Report

Merging #13142 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13142   +/-   ##
=======================================
  Coverage   42.07%   42.07%           
=======================================
  Files         681      681           
  Lines       75121    75121           
=======================================
+ Hits        31608    31610    +2     
  Misses      38361    38361           
+ Partials     5152     5150    -2
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/error.go 33.88% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
modules/git/repo.go 46.70% <0.00%> (+0.50%) ⬆️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
modules/git/repo_language_stats.go 56.60% <0.00%> (+3.77%) ⬆️
modules/indexer/stats/db.go 60.86% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa7404...887d4b2. Read the comment docs.

6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@6543 6543 removed the pr/wip This PR is not ready for review label Oct 14, 2020
techknowlogick
techknowlogick reviewed Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@6543 @techknowlogick
Apply suggestions from code review
25cfa3c 
Co-authored-by: techknowlogick <matti@mdranta.net>
zeripath
zeripath reviewed Oct 14, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@6543 @zeripath
Apply suggestions from code review
7495883 
Co-authored-by: zeripath <art27@cantab.net>
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@zeripath @6543
Apply suggestions from code review
50630dc 
Co-authored-by: 6543 <6543@obermui.de>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 14, 2020
6543
6543 commented Oct 14, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Oct 14, 2020

@zeripath moved 12689,13056,13058 into sec topic - still ok?

@zeripath
Copy link
Contributor

yeah fine

6543
6543 commented Oct 14, 2020
View reviewed changes
Copy link
Member Author

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 14, 2020
@techknowlogick techknowlogick merged commit 33e0e37 into go-gitea:master Oct 14, 2020
@6543 6543 deleted the changelog_v1.13.0 branch October 14, 2020 18:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@6543 @lunny @codecov-io @zeripath @techknowlogick @GiteaBot