Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vendor] Update go-version to v1.2.4 #13169

Merged
merged 2 commits into from
Oct 16, 2020
Merged

[Vendor] Update go-version to v1.2.4 #13169

merged 2 commits into from
Oct 16, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 16, 2020

  • github.com/6543/go-version v1.2.3 -> v1.2.4

close #13067

@6543 6543 mentioned this pull request Oct 16, 2020
Closed
2 tasks
@6543 6543 added this to the 1.14.0 milestone Oct 16, 2020
techknowlogick
techknowlogick reviewed Oct 16, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests? To either Gitea or the library itself?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 16, 2020
@6543
Copy link
Member Author

6543 commented Oct 16, 2020 •
edited
Loading

@techknowlogick

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 16, 2020
@codecov-io
Copy link

Codecov Report

Merging #13169 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13169      +/-   ##
==========================================
- Coverage   42.08%   42.07%   -0.01%     
==========================================
  Files         681      681              
  Lines       75115    75115              
==========================================
- Hits        31609    31604       -5     
- Misses      38352    38357       +5     
  Partials     5154     5154
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
modules/git/blame.go 75.43% <0.00%> (-1.76%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
services/mirror/mirror.go 18.51% <0.00%> (-1.35%) ⬇️
models/notification.go 65.76% <0.00%> (-0.91%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fbe645...14b8735. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 16, 2020
@6543
Copy link
Member Author

6543 commented Oct 16, 2020

🚀

@lafriks lafriks merged commit b222dbc into go-gitea:master Oct 16, 2020
@lafriks lafriks deleted the vendor_go-version_13067 branch October 16, 2020 09:05
@lafriks
Copy link
Member

lafriks commented Oct 16, 2020

please send backport

6543 added a commit to 6543-forks/gitea that referenced this pull request Oct 16, 2020
@6543 @zeripath
Update go-version v1.2.3 -> v1.2.4 (go-gitea#13169)
c24fdc8 
Co-authored-by: zeripath <art27@cantab.net>
@6543 6543 mentioned this pull request Oct 16, 2020
Merged
@6543
Copy link
Member Author

6543 commented Oct 16, 2020

Backport -> #13172

@6543 6543 added the backport/done All backports for this PR have been created label Oct 16, 2020
techknowlogick pushed a commit that referenced this pull request Oct 16, 2020
@6543 @zeripath
Update go-version v1.2.3 -> v1.2.4 (#13169) (#13172)
ea95a9f 
Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 16, 2020
@ivanvc
Merge remote-tracking branch 'origin/master' into update-outdated-com…
65328d9 
…ments-in-pull-request-label-style

* origin/master:
  [skip ci] Updated translations via Crowdin
  Fix diff skipping lines (go-gitea#13154)
  Update go-version v1.2.3 -> v1.2.4 (go-gitea#13169)
  Vendor Update Go Libs (go-gitea#13166)
  Prevent panics with missing storage (go-gitea#13164)
  Improve users management through the CLI (go-gitea#6001) (go-gitea#10492)
  Change order of possible-owner organizations to alphabetical (go-gitea#13160)
  Slightly simplify the queue settings code to help reduce the risk of problems (go-gitea#12976)
  [Vendor] Update go-ldap to v3.2.4 (go-gitea#13163)
  [skip ci] Updated translations via Crowdin
  Update external-renderers.en-us.md (go-gitea#13165)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Gitea fails to start with git 2.29.0.rc0.261.g7178c9af9c
6 participants
@6543 @codecov-io @lafriks @techknowlogick @zeripath @GiteaBot