-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mentionable teams to tributeValues and change team mention rules to gh's style #13198
Conversation
Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 avatar bug: use the same icon as with pullreview-requested-teams: |
I'd use the org avatar if possible |
Imho we should prefix them with org name and other possibility is to use specific group icon |
Co-authored-by: silverwind <me@silverwind.io>
* use org's avator as team avator in ui Signed-off-by: a1012112796 <1012112796@qq.com>
I think maybe we should support mention anyone at first. |
This comment has been minimized.
This comment has been minimized.
No. I mean currently we can only mention the orgnizaion members. We should allow to mention anyone in this Gitea instance. |
you can mention anyone now. but not support hint on ui now. gitea only add all assignees and participants to the list now. |
Codecov Report
@@ Coverage Diff @@
## master #13198 +/- ##
=======================================
Coverage 42.32% 42.33%
=======================================
Files 726 726
Lines 77689 77752 +63
=======================================
+ Hits 32885 32915 +30
- Misses 39406 39431 +25
- Partials 5398 5406 +8
Continue to review full report at Codecov.
|
I generally think those mentions need to be rewritten to use a AJAX call to obtain the mentionees. I think tribute.js already supports async loading of data. Doesn't need to be done in this PR but would be nice to have. |
Co-authored-by: Lauris BH <lauris@nix.lv>
As title, example view:
![image](https://user-images.githubusercontent.com/25342410/96476320-a1c66f80-1267-11eb-9885-0f945f0f3cd4.png)
TODO: