Fix Storage mapping #13297
Merged
Fix Storage mapping #13297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default STORAGE_TYPE should be the provided type. Fix go-gitea#13286 Signed-off-by: Andrew Thornton <art27@cantab.net>
…-default-storage-type-to-passed-in-type
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
changed the title
lunny
approved these changes
Oct 25, 2020
zeripath
force-pushed
the
fix-13286-Set-default-storage-type-to-passed-in-type
branch
from
a4724ed
to
4d2b7b5
Compare
lafriks
approved these changes
Oct 25, 2020
|
Really sorry about this. |
Codecov Report
@@ Coverage Diff @@
## master #13297 +/- ##
==========================================
+ Coverage 42.10% 42.13% +0.03%
==========================================
Files 689 689
Lines 75721 75764 +43
==========================================
+ Hits 31881 31926 +45
+ Misses 38610 38607 -3
- Partials 5230 5231 +1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/done
zeripath
deleted the
fix-13286-Set-default-storage-type-to-passed-in-type
branch
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 25, 2020
Backport go-gitea#13297 This PR fixes several bugs in setting storage * The default STORAGE_TYPE should be the provided type. * The Storage config should be passed in to NewStorage as a pointer - otherwise the Mappable interface function MapTo will not be found * There was a bug in the MapTo function. Fix go-gitea#13286 Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Fix Storage mapping (#13297) Backport #13297 This PR fixes several bugs in setting storage * The default STORAGE_TYPE should be the provided type. * The Storage config should be passed in to NewStorage as a pointer - otherwise the Mappable interface function MapTo will not be found * There was a bug in the MapTo function. Fix #13286 Signed-off-by: Andrew Thornton <art27@cantab.net> * add missing changes from backport #13164 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
ivanvc
added a commit
to ivanvc/gitea
that referenced
this pull request
Oct 27, 2020
…s-stored-in-email-address-table * origin/master: [UI] Hide consecutive additions and removals of the same label (go-gitea#13315) [skip ci] Updated translations via Crowdin Fix send mail (go-gitea#13312) [skip ci] Updated translations via Crowdin Deny wrong pull (go-gitea#13308) Group Label Changed Comments in timeline (go-gitea#13304) [skip ci] Updated translations via Crowdin Attempt to handle unready PR in tests (go-gitea#13305) go-gitea#12897 - add mastodon provider (go-gitea#13293) [skip ci] Updated translations via Crowdin Fix Storage mapping (go-gitea#13297) Update Mirror IsEmpty status on synchronize (go-gitea#13185) Fix bug isEnd detection on getIssues/getPullRequests (go-gitea#13299) systemd service: Add commented PATH environment option for Git prefix (go-gitea#13170) Sendmail command (go-gitea#13079) Various UI and arc-green fixes (go-gitea#13291)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several bugs in setting storage
Fix #13286
Signed-off-by: Andrew Thornton art27@cantab.net