Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Highlighting #1337

Closed
hughesjs opened this issue Mar 20, 2017 · 24 comments
Closed

Syntax Highlighting #1337

hughesjs opened this issue Mar 20, 2017 · 24 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Milestone

Comments

@hughesjs
Copy link

I only develop in C# so it might not be the same for all languages. However, it appears to myself, and those within my team that the syntax highlighting is very lacklustre and not really useful for much.

Could we consider moving towards a better syntax highlighting library?

@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 20, 2017
@lunny lunny added this to the 1.x.x milestone Mar 20, 2017
@andreynering
Copy link
Contributor

Sorry for taking so much time to respond...

Can you give us an example? Maybe a C# file example and a screenshot.

@ShalokShalom
Copy link

ShalokShalom commented Jan 14, 2018

This seems related: #2994

@depau
Copy link

depau commented Sep 1, 2018

I'll add myself here as I'm noticing Kotlin is not supported.

@ShalokShalom
Copy link

ShalokShalom commented Sep 1, 2018

Syntax highlighting is still a heavy issue in Gitea as it seems. Is it suitable to put some focus on this?
It seems a critical part of the whole experience to me. Thanks :)

@hughesjs
Copy link
Author

hughesjs commented Sep 6, 2018

Chroma looks promising... https://github.com/alecthomas/chroma

@ShalokShalom
Copy link

Looks good 👍

@hughesjs
Copy link
Author

hughesjs commented Sep 7, 2018

I'm a C# guy and don't have time to be delving into Go right now but if nobody has taken this up in a few weeks I'll have a crack

@stale
Copy link

stale bot commented Jan 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 11, 2019
@ShalokShalom
Copy link

I think this could be considered as something fundamental.

@stale stale bot removed the issue/stale label Jan 13, 2019
@stale
Copy link

stale bot commented Mar 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Mar 14, 2019
@lafriks lafriks added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Mar 27, 2019
@stale stale bot removed the issue/stale label Mar 27, 2019
@Stegosawr
Copy link

Syntax highlighting for ABAP is not working correctly too. Would be very nice if that would change. I attached a example file.
image

(Sorry that the comments are in german, but I think you'll get the point)

@ShalokShalom
Copy link

Could we set a bounty on https://github.com/alecthomas/chroma

@Stegosawr
Copy link

Stegosawr commented Sep 17, 2019

Created a Issue on Chroma.

Update:
Someone said he's working on it :)

@Stegosawr
Copy link

Stegosawr commented Sep 20, 2019

Chroma now has ABAP support. Thanks for everyones help.

@ShalokShalom
Copy link

Yeah, just Chroma isnt implemented in Gitea yet?

@lunny
Copy link
Member

lunny commented Sep 21, 2019

@ShalokShalom not yet.

@ShalokShalom
Copy link

Thanks a lot. So it seems you consider it as an option? Is it already on some plan?

@FunctionalHacker
Copy link

Has anyone considered tree-sitter?

@Martmists-GH
Copy link

An alternative many websites use is Highlight.js

@ShalokShalom
Copy link

So far as I know is Go prefered.

@jolheiser
Copy link
Member

An alternative many websites use is Highlight.js

This is what Gitea currently uses.

@Martmists-GH
Copy link

Huh, I'm not seeing any highlighting at all on my repos

@GitMensch
Copy link

I think this can be closed in favor of #7729, couldn't it?

@lunny
Copy link
Member

lunny commented Jul 7, 2020

Closed by #12047

@lunny lunny closed this as completed Jul 7, 2020
@lunny lunny modified the milestones: 1.x.x, 1.13.0 Jul 7, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests