Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker/rootless: Remove specific indexer path #13388

Merged
merged 2 commits into from Nov 1, 2020

Conversation

sapk
Copy link
Member

@sapk sapk commented Nov 1, 2020

Relooking at default configuration we shouldn't define a specific path for indexer of issue especially since it wouldn't be the same as other default indexers paths.

For details on default values: https://github.com/go-gitea/gitea/blob/master/custom/conf/app.example.ini#L447

@sapk sapk changed the title Remove specific indexer path Docker/rootless: Remove specific indexer path Nov 1, 2020
@sapk sapk added topic/distribution This PR changes something about the packaging of Gitea skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 1, 2020
@codecov-io
Copy link

codecov-io commented Nov 1, 2020

Codecov Report

Merging #13388 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13388      +/-   ##
==========================================
- Coverage   42.14%   42.14%   -0.01%     
==========================================
  Files         691      691              
  Lines       75966    75966              
==========================================
- Hits        32019    32016       -3     
- Misses      38703    38705       +2     
- Partials     5244     5245       +1     
Impacted Files Coverage Δ
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 48.90% <0.00%> (-2.92%) ⬇️
modules/charset/charset.go 70.78% <0.00%> (-2.25%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
services/gitdiff/gitdiff.go 68.54% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8176ba6...d35f309. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 1, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Nov 1, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 1, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2020
@techknowlogick techknowlogick merged commit 563165a into master Nov 1, 2020
@techknowlogick techknowlogick deleted the docker-rootless-rm-indexer-path branch November 1, 2020 23:34
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/distribution This PR changes something about the packaging of Gitea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants