Comments on review should have the same sha #13448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s page This happened because the comment took the latest commitID as its base instead of the reviewID that it was replying to. There was also no way of creating an already outdated comment - and a reply to a review on an outdated line should be outdated. Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Whilst the migration was broken the correct solution should have been to no-op the migration not revert the whole commit. In any case hopefully this fixes the migration. |
GiteaBot
added
the
lgtm/need 2
…com:zeripath/gitea into comments-on-review-should-have-the-same-sha
lafriks
approved these changes
Nov 6, 2020
GiteaBot
added
lgtm/need 1
|
CI randomly failed but may not relate to this. |
|
Unfortunately the mssql code is incorrect |
|
mssql: Only one expression can be specified in the select list when the subquery is not introduced with EXISTS. |
lunny
reviewed
Nov 7, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
approved these changes
Nov 9, 2020
GiteaBot
added
lgtm/done
|
🚀 |
|
This may have caused a regression in 1.13 #13683. Could someone have a look at that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore #13217