Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Fix GetQueryBeforeSince #13559

Merged
merged 1 commit into from
Nov 14, 2020
Merged

API: Fix GetQueryBeforeSince #13559

merged 1 commit into from
Nov 14, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 14, 2020 •
edited

bug found while working on #13514

tld: sometimes the time is not unescaped and so it can not be parsed

@6543 6543 added this to the 1.14.0 milestone Nov 14, 2020
@6543 6543 added modifies/api This PR adds API routes or modifies them type/bug labels Nov 14, 2020
This was referenced Nov 14, 2020
Merged
Merged
@6543
Copy link
Member Author

6543 commented Nov 14, 2020

Backports: #13560, #13561

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 14, 2020
@6543 6543 added the backport/done All backports for this PR have been created label Nov 14, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #13559 (d642540) into master (374ff60) will decrease coverage by 0.01%.
The diff coverage is 48.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13559      +/-   ##
==========================================
- Coverage   42.17%   42.15%   -0.02%     
==========================================
  Files         696      696              
  Lines       76437    76447      +10     
==========================================
- Hits        32240    32230      -10     
- Misses      38912    38926      +14     
- Partials     5285     5291       +6
Impacted Files Coverage Δ
routers/api/v1/notify/repo.go 72.97% <0.00%> (ø)
routers/api/v1/notify/user.go 25.00% <0.00%> (ø)
routers/api/v1/repo/issue_comment.go 34.05% <0.00%> (ø)
routers/api/v1/repo/issue_tracked_time.go 19.79% <0.00%> (ø)
routers/api/v1/utils/utils.go 66.66% <62.50%> (-13.34%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-3.27%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374ff60...d642540. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 14, 2020
@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit 3f3447a into go-gitea:master Nov 14, 2020
@zeripath zeripath deleted the api_fix-parse-time branch November 14, 2020 14:05
techknowlogick pushed a commit that referenced this pull request Nov 15, 2020
@6543 @zeripath
API: Fix GetQueryBeforeSince (#13559) (#13560)
f964888 
* API: Fix GetQueryBeforeSince

* CI.restart()

Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@6543 @codecov-io @zeripath @lafriks @GiteaBot